Merge lp:~camptocamp/account-invoice-report/add-domain into lp:~account-core-editors/account-invoice-report/7.0

Proposed by Nicolas Bessi - Camptocamp
Status: Merged
Merged at revision: 17
Proposed branch: lp:~camptocamp/account-invoice-report/add-domain
Merge into: lp:~account-core-editors/account-invoice-report/7.0
Diff against target: 28 lines (+5/-3)
2 files modified
invoice_webkit/__openerp__.py (+1/-1)
invoice_webkit/invoice.py (+4/-2)
To merge this branch: bzr merge lp:~camptocamp/account-invoice-report/add-domain
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+146124@code.launchpad.net

This proposal supersedes a proposal from 2013-02-01.

Description of the change

add domain on text condition relation

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote : Posted in a previous version of this proposal

LGTM

review: Approve (code review, no test)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote : Posted in a previous version of this proposal

when you change the data model, please increment the version in __openerp__.py

review: Needs Fixing (code review, no test)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

+1

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'invoice_webkit/__openerp__.py'
2--- invoice_webkit/__openerp__.py 2013-01-24 15:28:47 +0000
3+++ invoice_webkit/__openerp__.py 2013-02-01 13:51:24 +0000
4@@ -20,7 +20,7 @@
5 ##############################################################################
6
7 { 'name': 'Invoice Report using Webkit Library',
8- 'version': '1.0',
9+ 'version': '1.1.0',
10 'category': 'Reports/Webkit',
11 'description': """
12 Replaces the legacy rml Invoice report by a brand new webkit report.
13
14=== modified file 'invoice_webkit/invoice.py'
15--- invoice_webkit/invoice.py 2013-01-30 10:46:33 +0000
16+++ invoice_webkit/invoice.py 2013-02-01 13:51:24 +0000
17@@ -55,8 +55,10 @@
18 def set_footer(self, cr, uid, inv_id, commentid):
19 return self._set_condition(cr, uid, inv_id, commentid, 'note2')
20
21- _columns = {'text_condition1': fields.many2one('account.condition_text', 'Header condition'),
22- 'text_condition2': fields.many2one('account.condition_text', 'Footer condition'),
23+ _columns = {'text_condition1': fields.many2one('account.condition_text', 'Header condition',
24+ domain=[('type', '=', 'header')]),
25+ 'text_condition2': fields.many2one('account.condition_text', 'Footer condition',
26+ domain=[('type', '=', 'footer')]),
27 'note1': fields.html('Header'),
28 'note2': fields.html('Footer'),}
29

Subscribers

People subscribed via source and target branches