Merge lp:~camptocamp/account-financial-tools/fix-1189922 into lp:~account-core-editors/account-financial-tools/7.0

[Nicolas Bessi - Camptocamp]

fix bug 1189922 that prevents validation of invoices with 0% export tax. Because it creates zero amount move line(s).

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Why do you cast bool for the first condition?
This condition leads to confusion especially when we have to deal with the precedence (+ has a higher precedence than 'not', while 'and' has a lower precedence than 'not').

Seems simpler to me:

    if not (l.debit and l.credit):
        continue
    if bool(l.currency_id) != bool(l.amount_currency):
        return False

review: Needs Fixing

[lp:~camptocamp/account-financial-tools/fix-1189922]

115. By Nicolas Bessi - Camptocamp on 2013-07-11

[IMP] code styling

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Fix commited

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Thanks for the changes.
LGTM

review: Approve (code review, no test)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

review: Approve (code)

=== modified file 'account_constraints/account_constraints.py'
--- account_constraints/account_constraints.py	2013-02-06 09:42:14 +0000
+++ account_constraints/account_constraints.py	2013-07-11 08:35:33 +0000
@@ -122,8 +122,10 @@
 
     def _check_currency_and_amount(self, cr, uid, ids, context=None):
         for l in self.browse(cr, uid, ids, context=context):
-            if ((l.currency_id and not l.amount_currency) or
-                    (not l.currency_id and l.amount_currency)):
+            # we check zero amount line
+            if not (l.debit and l.credit):
+                continue
+            if bool(l.currency_id) != bool(l.amount_currency):
                 return False
         return True