Merge lp:~camptocamp/account-financial-tools/account_cancel_invoice_check_voucher into lp:~account-core-editors/account-financial-tools/7.0

[Vincent Renaville@camptocamp]

[ADD] account_cancel_invoice_check_voucher : contraint to not be able to cancel an invoice already import in bank statement with a voucher

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Same comments than https://code.launchpad.net/~c2c/account-financial-tools/account_cancel_invoice_check_payment_order/+merge/143264

review: Needs Fixing

[lp:~camptocamp/account-financial-tools/account_cancel_invoice_check_voucher]

98. By Vincent Renaville@camptocamp on 2013-01-16

[FIX] correction regarding Guewen Baconnier @ Camptocamp comments

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Hello,

It seems you did not take the corrected description form other branch in __openerp__.py.
You should avoid one character variable, i is not meaningful inv is a better name.
Line 113 is too long.

Nicolas

review: Needs Fixing

[lp:~camptocamp/account-financial-tools/account_cancel_invoice_check_voucher]

99. By Alexandre Fayolle - camptocamp on 2013-01-30

[IMP] a few points:

* typos in strings
* capitalize all SQL keywords in the query
* fixed prototype of action_cancel in 7.0

100. By Vincent Renaville@camptocamp on 2013-02-11

[FIX] improve sql query

Unmerged revisions

=== added directory 'account_cancel_invoice_check_voucher'
=== added file 'account_cancel_invoice_check_voucher/__init__.py'
--- account_cancel_invoice_check_voucher/__init__.py	1970-01-01 00:00:00 +0000
+++ account_cancel_invoice_check_voucher/__init__.py	2013-01-16 09:09:27 +0000
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author Vincent Renaville. Copyright 2012 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import account_invoice
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+

=== added file 'account_cancel_invoice_check_voucher/__openerp__.py'
--- account_cancel_invoice_check_voucher/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_cancel_invoice_check_voucher/__openerp__.py	2013-01-16 09:09:27 +0000
@@ -0,0 +1,32 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author Vincent Renaville. Copyright 2012 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    "name" : "Cancel invoice, check on bank statement",
+    "version" : "1.0",
+    "depends" : ["base", "account","account_voucher","account_cancel"],
+    "author" : "Camptocamp",
+    "description": """Contraint to not be able to cancel an invoice already import in bank statement with a voucher
+    """,
+    'website': 'http://www.camptocamp.com',
+    'date' : [],
+    'installable': True,
+    'active': False,
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'account_cancel_invoice_check_voucher/account_invoice.py'
--- account_cancel_invoice_check_voucher/account_invoice.py	1970-01-01 00:00:00 +0000
+++ account_cancel_invoice_check_voucher/account_invoice.py	2013-01-16 09:09:27 +0000
@@ -0,0 +1,52 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+# Copyright (c) 2012 Camptocamp (http://www.camptocamp.com) 
+# All Right Reserved
+#
+# Author : Vincent Renaville (Camptocamp)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.tools.translate import _
+from openerp.osv import osv, orm
+
+class account_invoice(orm.TransientModel):
+    _inherit = "account.invoice"
+    
+    def action_cancel(self, cr, uid, ids, *args):
+        invoices = self.read(cr, uid, ids, ['move_id', 'payment_ids'])
+        for i in invoices:
+            if i['move_id']:
+                ## This invoice have a move line, we search move_line concerned by this move
+                cr.execute("""SELECT abs.name as statement_name,
+                                     abs.date as statement_date,
+                                     absl.name
+                              FROM account_bank_statement_line as absl
+                              INNER JOIN account_bank_statement as abs
+                              ON absl.statement_id = abs.id
+                              WHERE voucher_id in 
+                                        ( SELECT voucher_id FROM account_voucher_line WHERE move_line_id in 
+                                            (SELECT id FROM account_move_line WHERE move_id = %s )) limit 1""", (i['move_id'][0],))
+                statement_lines = cr.dictfetchone()
+                if statement_lines:
+                    raise osv.except_osv(_('Error !'), 
+                                         _('Invoice already import in bank statment (%s) at %s on line %s'
+                                            % (statement_lines['statement_name'],
+                                               statement_lines['statement_date'],
+                                               statement_lines['name'],)))
+
+        return super(account_invoice,self).action_cancel(cr, uid, ids, *args)
\ No newline at end of file