Merge lp:~camptocamp/account-financial-tools/account-contraints-state-vre into lp:~account-core-editors/account-financial-tools/7.0

[Vincent Renaville@camptocamp]

Hello,

When you generate entries lines from the previous year, the wizard validate all move lines from the previous year.
The constraint will raise because, the field state is not in the authorized field like reconcile_id and partial_reconcile_id
My fix add state in the authorised fields.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Does this change allow to change a move from 'posted' to 'unposted' when it should not have been allowed? This constraint does maybe exist elsewhere, if it it does, so your fix seems correct to me. Otherwise, we should check that that the change is unposted→posted and not posted→unposted.

review: Needs Information

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi,

My opinion here that this fix is dangerous. The name of the method that use it is "_authorized_reconcile", which means, we check reconcile stuff not state stuff... The problem comes from another place.

May be you should use the "flag" : if not context.get('from_parent_object', False):

Add from_parent_object in context in the wizard that generate the end of year entries and you should not face this trouble anymore.

But please, do not allow state change, this is why we introduce the constraints ;)

Thanks,

Joël

review: Disapprove (code review, no tests)

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Work needed for this one.

I set it in WIP

Unmerged revisions

125. By Vincent Renaville@camptocamp on 2013-11-05

[FIX] add state in authorized field to be write, due to Generate new fiscalyear wizard, that revalid current year move line

=== modified file 'account_constraints/account_constraints.py'
--- account_constraints/account_constraints.py	2013-07-11 08:33:18 +0000
+++ account_constraints/account_constraints.py	2013-11-05 07:08:40 +0000
@@ -51,7 +51,7 @@
         """
         if not vals:
             return False
-        rec_keys = set(["reconcile_id", "reconcile_partial_id"])
+        rec_keys = set(["reconcile_id", "reconcile_partial_id", "state"])
         write_keys = set(vals)
         return rec_keys.issuperset(write_keys)