Merge lp:~camptocamp/account-financial-report/account_csv_VRE into lp:~account-report-core-editor/account-financial-report/7.0

[Vincent Renaville@camptocamp]

Add account_export_csv, that allow to export Trial Balance and Analytic Balance with accounts in CSV

I have change the license in this merge proposal

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi,

Thanks for this merge. My comments:

 - Use coding instead of encoding in file header

 - Split line 412

 - In account_export_csv.py, only 1 line after each method not more

 - get_data and get_data_analytic are so similar, I'd love to see the factorize by passing an args on which method to call (_analytic or _account) + renaming the _get_header_analytic, _get_row_analytic, _get_header and _get_row accordingly (e.g. _get_header_account and _get_header_analytic)

Otherwise it look good to me.

Regards,

review: Needs Fixing (code review, no test, no translation review)

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Thanks for your review

I will work on that , I will resubmit the fixes soon

Vincent

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Joel, I have fix according to your comment

Thanks for your review

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Hello,
I have improve the SQl for analytic in order to take also move line without analytic account

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

LGTM

review: Approve (code review, no test)

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Thanks for fixing, it LGTM !

review: Approve (code review, no test)

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Thanks for fixing, it LGTM !

review: Approve (thanks for fixing, it lgtm !)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

The _get_rows_account and _get_rows_analytic methods take a 'company_id' argument, this one is passed to the query, but this one does not use it, so the lines are not multi-company aware.
I'm not sure if it should be done directly in the query or if you should leave the query as is and do a self.search(cr, uid, [('id', 'in', line_ids)], context=context) afterwards to apply the rules.

review: Needs Fixing

=== added directory 'account_export_csv'
=== added file 'account_export_csv/__init__.py'
--- account_export_csv/__init__.py	1970-01-01 00:00:00 +0000
+++ account_export_csv/__init__.py	2013-04-16 08:33:27 +0000
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author Joel Grand-Guillaume and Vincent Renaville Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import wizard
\ No newline at end of file

=== added file 'account_export_csv/__openerp__.py'
--- account_export_csv/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_export_csv/__openerp__.py	2013-04-16 08:33:27 +0000
@@ -0,0 +1,46 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author Joel Grand-Guillaume and Vincent Renaville Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name' : 'Account Export CSV',
+    'version' : '1',
+    'depends' : [
+                 'account', 
+                 ],
+    'author' : 'Camptocamp',
+    'description': """
+    
+    Add a wizard that allow you to export a csv file based on accounting journal entries 
+    
+    - Trial Balance
+    - Analytic Balance (with accounts)
+    
+    You can filter by period 
+    
+     
+    """,
+    'website': 'http://www.camptocamp.com',
+    'data': [
+            'wizard/account_export_csv_view.xml',
+            'menu.xml',
+                  ],
+    'installable': True,
+    'active': False,
+}

=== added directory 'account_export_csv/i18n'
=== added file 'account_export_csv/i18n/account_export_csv.po'
--- account_export_csv/i18n/account_export_csv.po	1970-01-01 00:00:00 +0000
+++ account_export_csv/i18n/account_export_csv.po	2013-04-16 08:33:27 +0000
@@ -0,0 +1,111 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#   * account_export_csv
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2013-04-10 15:11+0000\n"
+"PO-Revision-Date: 2013-04-10 15:11+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: account_export_csv
+#: model:ir.model,name:account_export_csv.model_account_csv_export
+msgid "Export Accounting"
+msgstr ""
+
+#. module: account_export_csv
+#: field:account.csv.export,export_filename:0
+msgid "Export CSV Filename"
+msgstr ""
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+msgid "Trial Balance"
+msgstr ""
+
+#. module: account_export_csv
+#: field:account.csv.export,company_id:0
+msgid "Company"
+msgstr ""
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+msgid "Analytic Balance (with accounts)"
+msgstr ""
+
+#. module: account_export_csv
+#: help:account.csv.export,periods:0
+msgid "All periods in the fiscal year if empty"
+msgstr ""
+
+#. module: account_export_csv
+#: field:account.csv.export,periods:0
+msgid "Periods"
+msgstr ""
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+msgid "Close"
+msgstr ""
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+#: model:ir.actions.act_window,name:account_export_csv.action_account_csv_export
+#: model:ir.ui.menu,name:account_export_csv.menu_account_csv_export
+msgid "Accounting CSV Export"
+msgstr ""
+
+#. module: account_export_csv
+#: field:account.csv.export,data:0
+msgid "CSV"
+msgstr ""
+
+#. module: account_export_csv
+#: field:account.csv.export,fiscalyear_id:0
+msgid "Fiscalyear"
+msgstr ""
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+msgid "Analytic Balance (with accounts)"
+msgstr ""
+
+#. module: account_export_csv
+#: field:account.csv.export,stop_period_id:0
+msgid "End period"
+msgstr ""
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+msgid "Close"
+msgstr ""
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+#: model:ir.actions.act_window,name:account_export_csv.action_account_csv_export
+#: model:ir.ui.menu,name:account_export_csv.menu_account_csv_export
+msgid "Accounting CSV Export"
+msgstr ""
+
+#. module: account_export_csv
+#: field:account.csv.export,data:0
+msgid "CSV"
+msgstr ""
+
+#. module: account_export_csv
+#: model:ir.model,name:account_export_csv.model_account_csv_export
+msgid "Export Accounting Entries"
+msgstr ""
+
+#. module: account_export_csv
+#: field:account.csv.export,fiscalyear_id:0
+msgid "Fiscalyear"
+msgstr ""
+

=== added file 'account_export_csv/i18n/fr.po'
--- account_export_csv/i18n/fr.po	1970-01-01 00:00:00 +0000
+++ account_export_csv/i18n/fr.po	2013-04-16 08:33:27 +0000
@@ -0,0 +1,74 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#   * account_export_csv
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2013-04-10 15:11+0000\n"
+"PO-Revision-Date: 2013-04-10 15:11+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: account_export_csv
+#: model:ir.model,name:account_export_csv.model_account_csv_export
+msgid "Export Accounting"
+msgstr "Export comptable"
+
+#. module: account_export_csv
+#: field:account.csv.export,export_filename:0
+msgid "Export CSV Filename"
+msgstr "Nom du fichier CSV d'export"
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+msgid "Trial Balance"
+msgstr "Balance générale"
+
+#. module: account_export_csv
+#: field:account.csv.export,company_id:0
+msgid "Company"
+msgstr "Société"
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+msgid "Analytic Balance (with accounts)"
+msgstr "Balance analytique (avec comptes)"
+
+#. module: account_export_csv
+#: help:account.csv.export,periods:0
+msgid "All periods in the fiscal year if empty"
+msgstr "Toutes les périodes de l'année fiscale si vide"
+
+#. module: account_export_csv
+#: field:account.csv.export,periods:0
+msgid "Periods"
+msgstr "Périodes"
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+msgid "Close"
+msgstr "Fermer"
+
+#. module: account_export_csv
+#: view:account.csv.export:0
+#: model:ir.actions.act_window,name:account_export_csv.action_account_csv_export
+#: model:ir.ui.menu,name:account_export_csv.menu_account_csv_export
+msgid "Accounting CSV Export"
+msgstr "Export comptable CSV"
+
+#. module: account_export_csv
+#: field:account.csv.export,data:0
+msgid "CSV"
+msgstr "CSV"
+
+#. module: account_export_csv
+#: field:account.csv.export,fiscalyear_id:0
+msgid "Fiscalyear"
+msgstr "Année fiscale"
+

=== added file 'account_export_csv/menu.xml'
--- account_export_csv/menu.xml	1970-01-01 00:00:00 +0000
+++ account_export_csv/menu.xml	2013-04-16 08:33:27 +0000
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+
+        <menuitem
+            icon="STOCK_EXECUTE"
+            name="Accounting CSV Export"
+            action="action_account_csv_export"
+            id="menu_account_csv_export"
+            parent="account.menu_finance_reports"
+            sequence="110"
+            />
+
+
+    </data>
+</openerp>

=== added directory 'account_export_csv/wizard'
=== added file 'account_export_csv/wizard/__init__.py'
--- account_export_csv/wizard/__init__.py	1970-01-01 00:00:00 +0000
+++ account_export_csv/wizard/__init__.py	2013-04-16 08:33:27 +0000
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author Joel Grand-Guillaume and Vincent Renaville Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import account_export_csv
\ No newline at end of file

=== added file 'account_export_csv/wizard/account_export_csv.py'
--- account_export_csv/wizard/account_export_csv.py	1970-01-01 00:00:00 +0000
+++ account_export_csv/wizard/account_export_csv.py	2013-04-16 08:33:27 +0000
@@ -0,0 +1,226 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author Joel Grand-Guillaume and Vincent Renaville Copyright 2013 Camptocamp SA
+#    CSV data formating inspired from http://docs.python.org/2.7/library/csv.html?highlight=csv#examples
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import time
+import StringIO
+import cStringIO
+import base64
+
+import csv
+import codecs
+
+from openerp.osv import orm, fields
+from openerp.tools.translate import _
+
+
+class AccountUnicodeWriter(object):
+    """
+    A CSV writer which will write rows to CSV file "f",
+    which is encoded in the given encoding.
+    """
+
+    def __init__(self, f, dialect=csv.excel, encoding="utf-8", **kwds):
+        # Redirect output to a queue
+        self.queue = cStringIO.StringIO()
+        # created a writer with Excel formating settings
+        self.writer = csv.writer(self.queue, dialect=dialect, **kwds)
+        self.stream = f
+        self.encoder = codecs.getincrementalencoder(encoding)()
+
+    def writerow(self, row):
+        #we ensure that we do not try to encode none or bool
+        row = [x or u'' for x in row]
+        
+        encoded_row = []
+        for c in row:
+            if type(c) == unicode:
+                encoded_row.append(c.encode("utf-8"))
+            else:
+                encoded_row.append(c)
+        
+        self.writer.writerow(encoded_row)
+        # Fetch UTF-8 output from the queue ...
+        data = self.queue.getvalue()
+        data = data.decode("utf-8")
+        # ... and reencode it into the target encoding
+        data = self.encoder.encode(data)
+        # write to the target stream
+        self.stream.write(data)
+        # empty queue
+        self.queue.truncate(0)
+
+    def writerows(self, rows):
+        for row in rows:
+            self.writerow(row)
+
+class AccountCSVExport(orm.TransientModel):
+    _name = 'account.csv.export'
+    _description = 'Export Accounting'
+
+    _columns = {
+        'data': fields.binary('CSV',readonly=True),
+        'company_id': fields.many2one('res.company', 'Company', invisible=True),
+        'fiscalyear_id': fields.many2one('account.fiscalyear', 'Fiscalyear', required=True),
+        'periods': fields.many2many('account.period','rel_wizard_period','wizard_id','period_id','Periods',help='All periods in the fiscal year if empty'),
+        'export_filename': fields.char('Export CSV Filename', size=128),
+    }
+
+    def _get_company_default(self, cr, uid, context=None):
+        comp_obj = self.pool['res.company']
+        return comp_obj._company_default_get(cr, uid, 'account.fiscalyear', context=context)
+
+    def _get_fiscalyear_default(self, cr, uid, context=None):
+        fiscalyear_obj = self.pool['account.fiscalyear']
+        context['company_id'] = self._get_company_default(cr, uid, context)
+        return fiscalyear_obj.find(cr,uid,dt=None,exception=True, context=context)
+
+    _defaults = {'company_id': _get_company_default,
+                 'fiscalyear_id' : _get_fiscalyear_default,
+                 'export_filename' : 'account_export.csv'}
+
+    def action_manual_export_account(self, cr, uid, ids, context=None):
+        this = self.browse(cr, uid, ids)[0]
+        rows = self.get_data(cr, uid, ids,"account", context)
+        file_data = StringIO.StringIO()
+        try:
+            writer = AccountUnicodeWriter(file_data)
+            writer.writerows(rows)
+            file_value = file_data.getvalue()
+            self.write(cr, uid, ids,
+                       {'data': base64.encodestring(file_value)},
+                       context=context)
+        finally:
+            file_data.close()
+        return {
+            'type': 'ir.actions.act_window',
+            'res_model': 'account.csv.export',
+            'view_mode': 'form',
+            'view_type': 'form',
+            'res_id': this.id,
+            'views': [(False, 'form')],
+            'target': 'new',
+        }
+
+
+    def _get_header_account(self, cr, uid, ids, context=None):
+        return [_(u'CODE'),
+                _(u'NAME'),
+                _(u'DEBIT'),
+                _(u'CREDIT'),
+                _(u'BALANCE'),
+                ]
+
+    def _get_rows_account(self, cr, uid, ids, fiscalyear_id,period_range_ids,company_id,context=None):
+        """
+        Return list to generate rows of the CSV file
+        """
+        cr.execute("""
+                        select ac.code,ac.name,
+                        sum(debit) as sum_debit,sum(credit) as sum_credit,sum(debit) - sum(credit) as balance
+                        from account_move_line as aml,account_account as ac
+                        where aml.account_id = ac.id
+                        and period_id in %(period_ids)s
+                        group by ac.id,ac.code,ac.name
+                        order by ac.code
+                   """,
+                    {'fiscalyear_id': fiscalyear_id,'company_id':company_id,'period_ids':tuple(period_range_ids)}
+                )
+        res = cr.fetchall()
+        
+        rows = []
+        for line in res:
+            rows.append(list(line))
+        return rows
+    
+    def action_manual_export_analytic(self, cr, uid, ids, context=None):
+        this = self.browse(cr, uid, ids)[0]
+        rows = self.get_data(cr, uid, ids,"analytic", context)
+        file_data = StringIO.StringIO()
+        try:
+            writer = AccountUnicodeWriter(file_data)
+            writer.writerows(rows)
+            file_value = file_data.getvalue()
+            self.write(cr, uid, ids,
+                       {'data': base64.encodestring(file_value)},
+                       context=context)
+        finally:
+            file_data.close()
+        return {
+            'type': 'ir.actions.act_window',
+            'res_model': 'account.csv.export',
+            'view_mode': 'form',
+            'view_type': 'form',
+            'res_id': this.id,
+            'views': [(False, 'form')],
+            'target': 'new',
+        }
+    
+    def _get_header_analytic(self, cr, uid, ids, context=None):
+        return [_(u'ANALYTIC CODE'),
+                _(u'ANALYTIC NAME'),
+                _(u'CODE'),
+                _(u'ACCOUNT NAME'),
+                _(u'DEBIT'),
+                _(u'CREDIT'),
+                _(u'BALANCE'),
+                ]
+
+    def _get_rows_analytic(self, cr, uid, ids, fiscalyear_id,period_range_ids,company_id,context=None):
+        """
+        Return list to generate rows of the CSV file
+        """
+        cr.execute("""  select aac.code as analytic_code,aac.name as analytic_name,ac.code,ac.name,
+                        sum(debit) as sum_debit,sum(credit) as sum_credit,sum(debit) - sum(credit) as balance
+                        from account_move_line 
+                        left outer join account_analytic_account as aac
+                        on (account_move_line.analytic_account_id = aac.id)
+                        inner join account_account as ac
+                        on account_move_line.account_id = ac.id
+                        and account_move_line.period_id in %(period_ids)s
+                        group by aac.id,aac.code,aac.name,ac.id,ac.code,ac.name
+                        order by aac.code
+                   """,
+                    {'fiscalyear_id': fiscalyear_id,'company_id':company_id,'period_ids':tuple(period_range_ids)}
+                )
+        res = cr.fetchall()
+        
+        rows = []
+        for line in res:
+            rows.append(list(line))
+        return rows
+
+    def get_data(self, cr, uid, ids,result_type,context=None):
+        get_header_func = getattr(self,("_get_header_%s"%(result_type)), None)
+        get_rows_func = getattr(self,("_get_rows_%s"%(result_type)), None)
+        form = self.browse(cr, uid, ids[0], context=context)
+        fiscalyear_id = form.fiscalyear_id.id
+        user_obj = self.pool.get('res.users')
+        company_id = user_obj.browse(cr, uid, uid).company_id.id
+        if form.periods:
+            period_range_ids = [x.id for x in form.periods]
+        else:
+            # If not period selected , we take all periods
+            p_obj = self.pool.get("account.period")
+            period_range_ids = p_obj.search(cr,uid,[('fiscalyear_id','=',fiscalyear_id)],context=context)
+        rows = []
+        rows.append(get_header_func(cr, uid, ids, context=context))
+        rows.extend(get_rows_func(cr, uid, ids, fiscalyear_id,period_range_ids,company_id, context=context))
+        return rows

=== added file 'account_export_csv/wizard/account_export_csv_view.xml'
--- account_export_csv/wizard/account_export_csv_view.xml	1970-01-01 00:00:00 +0000
+++ account_export_csv/wizard/account_export_csv_view.xml	2013-04-16 08:33:27 +0000
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+
+        <record id="account_csv_export_view" model="ir.ui.view">
+             <field name="name">Accounting Entries CSV Export</field>
+             <field name="model">account.csv.export</field>
+             <field name="type">form</field>
+             <field name="arch" type="xml">
+                <form string="Accounting CSV Export">
+                    <group colspan="4">
+                        <field name="company_id" />
+                        <field name="fiscalyear_id"  domain="[('company_id', '=', company_id)]"/>
+                     </group>
+                    <group colspan="4" col="2">
+                        <field name="periods" domain="[('state', '=', 'draft'),('fiscalyear_id','=',fiscalyear_id)]"/>
+                    </group>
+                   <separator string ="" colspan="4"/>
+                    <group colspan="4" col="3">
+                        <button special="cancel" string="Close" icon="gtk-cancel"/>
+                        <button name="action_manual_export_account" string="Trial Balance" type="object" icon="gtk-execute"/>
+                        <button name="action_manual_export_analytic" string="Analytic Balance (with accounts)" type="object" icon="gtk-execute"/>
+                     </group>
+                   <separator string ="" colspan="4"/>
+                    <group colspan="4">
+                        <field name="data" filename="export_filename"/>
+                     </group>
+
+                </form>
+             </field>
+         </record>
+
+        <record id="action_account_csv_export" model="ir.actions.act_window">
+             <field name="name">Accounting CSV Export</field>
+             <field name="res_model">account.csv.export</field>
+             <field name="type">ir.actions.act_window</field>
+             <field name="view_type">form</field>
+             <field name="view_mode">tree,form</field>
+             <field name="view_id" ref="account_csv_export_view"/>
+             <field name="context">{}</field>
+             <field name="target">new</field>
+       </record>
+
+    </data>
+</openerp>