Code review comment for lp:~camptocamp/account-financial-report/7.0-sync-afr_webkit-with-report_webkit

On 06/17/2014 09:29 PM, Stéphane Bidoul (Acsone) wrote:
> Review: Needs Fixing test
>
> Hi,
>
> Is it just me or this MP broke afr with ocb 7.0?
>
> Traceback (most recent call last):
> File "/home/openerp/instance/account-financial-report/account_financial_report_webkit/report/webkit_parser_header_fix.py", line 228, in create_single_pdf
> **parser_instance.localcontext)
> File "/home/openerp/instance/eggs/Mako-1.0.0-py2.7.egg/mako/template.py", line 443, in render
> return runtime._render(self, self.callable_, args, data)
> File "/home/openerp/instance/eggs/Mako-1.0.0-py2.7.egg/mako/runtime.py", line 803, in _render
> **_kwargs_for_callable(callable_, data))
> File "/home/openerp/instance/eggs/Mako-1.0.0-py2.7.egg/mako/runtime.py", line 835, in _render_context
> _exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
> File "/home/openerp/instance/eggs/Mako-1.0.0-py2.7.egg/mako/runtime.py", line 860, in _exec_template
> callable_(context, *args, **kwargs)
> File "memory:0x5184dd0", line 22, in render_body
> <%
> TypeError: translate_call() takes exactly 2 arguments (3 given)
>
>

It is necessary to be compatible with this change:
https://github.com/odoo/odoo/pull/56
That has been merged in official branches.

I didn't noticed that it was not working in ocb because in my local OCB
branch (which is a bit out of date), the patch was there:

revno: 10194 [merge]
author: <email address hidden>
committer: Leonardo Pistone <email address hidden>
branch nick: 7.0-ocb
timestamp: Wed 2014-05-21 10:58:28 +0200
message:
  Transmit parser_instance using partial function for mako translation
callback.

  This to remove parser_instance from attribute as it can cause race
condition
  on cursors.

But it is no longer there when I look in the current ocb-addons tree.

I guess we should propose the MP again on OCB

--
Guewen Baconnier
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne
Phone: +41 21 619 10 39
Office: +41 21 619 10 10
http://www.camptocamp.com/