Merge lp:~camptocamp/account-financial-report/7.0-account_financial_report_webkit-journals-all into lp:~account-report-core-editor/account-financial-report/7.0
Status: | Merged |
---|---|
Approved by: | Yannick Vaucher @ Camptocamp |
Approved revision: | 65 |
Merged at revision: | 74 |
Proposed branch: | lp:~camptocamp/account-financial-report/7.0-account_financial_report_webkit-journals-all |
Merge into: | lp:~account-report-core-editor/account-financial-report/7.0 |
Diff against target: |
73 lines (+7/-35) 3 files modified
account_financial_report_webkit/report_menus.xml (+7/-4) account_financial_report_webkit/wizard/print_journal.py (+0/-20) account_financial_report_webkit/wizard/print_journal_view.xml (+0/-11) |
To merge this branch: | bzr merge lp:~camptocamp/account-financial-report/7.0-account_financial_report_webkit-journals-all |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Frederic Clementi - Camptocamp | functional | Approve | |
Leonardo Pistone | code review | Approve | |
Review via email: mp+201352@code.launchpad.net |
Commit message
[CHG] allows to select all the journal types in the Journals report, remove the second menu (it was hidden because the action had the same name
Description of the change
Remove the artificial split between the "Sale/Purchase Journals" and the other journals.
In the 'account' module, there is 2 menus, one for "Sale/Purchase Journals" and one for the other Journals.
This split has been kept in the webkit report, but I propose to remove it. It was justified in the 'account' module because the output of the report was not the same for each menu. The report is always the same now, so we have no reasons to have 2 menus.
Moreover, the second menu (the one for Sales/Purchases) is hidden because the name of the action is the same than the other one (both were called "Journals"), so we have currently no way to print the sales/purchases journals.
LGTM