Code review comment for lp:~camptocamp/account-consolidation/account-consolidation-fix-mono-currency
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | # |
review:
Needs Fixing
(code review, no test)
Can a renaming of consol_company_id be considered?
line 549: "if balance" I thing this could be wrong, because of rounding errors. Are you sure you don't need to use the rounding methods available in the framework, or float_is_zero + a precision here?
line 603: you can't return None in a "public" method which can be called from xmlrpc. Either return False, or rename the method.