Merge lp:~camptocamp/account-budgeting/vre-budget-responsible-group into lp:~account-core-editors/account-budgeting/7.0

Proposed by Vincent Renaville@camptocamp
Status: Merged
Merged at revision: 76
Proposed branch: lp:~camptocamp/account-budgeting/vre-budget-responsible-group
Merge into: lp:~account-core-editors/account-budgeting/7.0
Diff against target: 37 lines (+12/-0)
3 files modified
budget/__openerp__.py (+1/-0)
budget/security/ir.model.access.csv (+1/-0)
budget/security/security.xml (+10/-0)
To merge this branch: bzr merge lp:~camptocamp/account-budgeting/vre-budget-responsible-group
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, test Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+223705@code.launchpad.net

Description of the change

Hello,

In some case, people need to create budget lines from project , without being a financial manager.

So I create a group Budget Responsible.

Vincent

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Don't you think it's better to put the group in any category?

Regards.

review: Needs Information (code review)
76. By Vincent Renaville@camptocamp

[IMP] add accounting and finance category

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote :

Hello,

Thanks for your review !
After discussion I have put the Category : Accounting And Finance

Vincent

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks for the change.

Regards.

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

Thanks

review: Approve (code review, test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'budget/__openerp__.py'
2--- budget/__openerp__.py 2014-04-23 13:53:39 +0000
3+++ budget/__openerp__.py 2014-06-19 14:46:29 +0000
4@@ -42,6 +42,7 @@
5 ],
6 "data": ["budget_view.xml",
7 "analytic_view.xml",
8+ "security/security.xml",
9 "security/ir.model.access.csv"
10 ],
11 "test": ["test/analytic_amount.yml"],
12
13=== modified file 'budget/security/ir.model.access.csv'
14--- budget/security/ir.model.access.csv 2013-12-16 15:36:16 +0000
15+++ budget/security/ir.model.access.csv 2014-06-19 14:46:29 +0000
16@@ -3,4 +3,5 @@
17 "access_budget_budget","budget.budget","model_budget_budget","account.group_account_manager",1,1,1,1
18 "access_budget_version","budget.version","model_budget_version","account.group_account_manager",1,1,1,1
19 "access_budget_line","budget.line","model_budget_line","account.group_account_manager",1,1,1,1
20+"access_budget_line_responsible","budget.line","model_budget_line","group_budget_responsible",1,1,1,1
21 "access_budget_allocation_type","budget.allocation","model_budget_allocation_type","account.group_account_manager",1,1,1,1
22\ No newline at end of file
23
24=== added file 'budget/security/security.xml'
25--- budget/security/security.xml 1970-01-01 00:00:00 +0000
26+++ budget/security/security.xml 2014-06-19 14:46:29 +0000
27@@ -0,0 +1,10 @@
28+<?xml version="1.0" encoding="utf-8"?>
29+<openerp>
30+ <data>
31+ <record model="res.groups" id="group_budget_responsible">
32+ <field name="name">Budget Responsible</field>
33+ <field name="category_id" ref="base.module_category_accounting_and_finance"/>
34+ </record>
35+
36+ </data>
37+</openerp>

Subscribers

People subscribed via source and target branches