Merge lp:~camptocamp-reviewer/purchase-wkfl/purchase_landed_costs-jge into lp:~purchase-core-editors/purchase-wkfl/7.0

Proposed by Joël Grand-Guillaume @ camptocamp
Status: Merged
Merged at revision: 22
Proposed branch: lp:~camptocamp-reviewer/purchase-wkfl/purchase_landed_costs-jge
Merge into: lp:~purchase-core-editors/purchase-wkfl/7.0
Diff against target: 16 lines (+2/-2)
1 file modified
purchase_landed_costs/stock.py (+2/-2)
To merge this branch: bzr merge lp:~camptocamp-reviewer/purchase-wkfl/purchase_landed_costs-jge
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+200510@code.launchpad.net

Description of the change

Hi,

Here is a little fix for a stupid mistake on the call to _logger.

Regards,

Joël

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'purchase_landed_costs/stock.py'
2--- purchase_landed_costs/stock.py 2013-12-12 15:34:53 +0000
3+++ purchase_landed_costs/stock.py 2014-01-06 10:45:16 +0000
4@@ -62,10 +62,10 @@
5 # standard_price instead of converting the result in EUR
6 # Reference : https://bugs.launchpad.net/ocb-addons/+bug/1238525
7 res = super(stock_partial_picking, self)._product_cost_for_average_update(cr, uid, move)
8- self._logger.debug('res stock_partial_picking `%s`', res)
9+ _logger.debug('Before res stock_partial_picking `%s`', res)
10 # Re-take the cost from the PO line landed_costs field
11 if move.purchase_line_id:
12 res['cost'] = (move.purchase_line_id.landed_costs /
13 move.purchase_line_id.product_qty)
14- self._logger.debug('res stock_partial_picking `%s`', res)
15+ _logger.debug('After res stock_partial_picking `%s`', res)
16 return res

Subscribers

People subscribed via source and target branches