Code review comment for ~calvinmwadime/ubuntu/+source/walinuxagent:mantic-2.9.1.1

Revision history for this message
Calvin Mwadime Makokha (calvinmwadime) wrote :

> From a quick glance, I see you are also submitting the same changes that
> landed in Noble. And I'd confirm that after seeing the "~23.10" in the version
> string. Is that right? If so, I's expect to see the Noble changelog entry (as-
> is in Noble) and then a new changelog entry simply stating the backport and
> any change needed for the backport (which does not seem needed here). When
> your sponsor uploads the package both changelog entry should be included in
> the .changes file.
>
> To make it more concrete, I'd expect something like this:
>
> walinuxagent (2.9.1.1-0ubuntu1~23.10) mantic; urgency=medium
>
> * Backport version from Noble to Mantic (LP: #2035331).
>
> -- Calvin Mwadime <email address hidden> Thu, 14 Mar 2024 12:10:06
> +0300
>
> walinuxagent (2.9.1.1-0ubuntu1) noble; urgency=medium
>
> [ Calvin Mwadime ]
> * New upstream version 2.9.1.1
> * debian/watch: Fix package version regex pattern
> * debian/docs: Remove the changelog
> * debian/install: add new udev rules
> * debian/patches:
> - Remove deprecated patches
> - Update list of supported ubuntu versions
> - Correctly point to the right dhcp client lease file
> - Update the cgroup handling to include v2
> * disable_udev_overrides.patch: Remove udev overrides in setup.py
> * debian: Make python unit tests work
> * debian: Remove upstart config
> * debian/control: Remove isc-dhcp-client
> * debian/manpages: Added manpages
>
> [ Christian Ehrhardt ]
> * d/control, d/compat: switch to compat level 13
> * d/rules, d/install: install services once
> * d/control: drop old unneeded X-Python3-Version statement
> * d/rules: stop using the old systemd dh sequence
> * d/control: add iproute2 build dependency (test only)
> * d/control: fix lintian priority-extra-is-replaced-by-priority-optional
> * d/install: move remaining things to /usr
>
> -- Calvin Mwadime <email address hidden> Thu, 30 Nov 2023 11:07:05
> +0300

Thanks for this information.

« Back to merge proposal