> Thanks for this MP Calvin. I tried to add in-line comments here but the diff
> is big enough to make LP not behave well. So here are my notes:
> 
> - d/p/disable_udev_overrides.patch
>   + In the DEP-3 headers there is no definition of Subject, I believe you
> wanted to use Description.
>   + If the setup.py already does the right thing (install the udev rules files
> in the correct place), maybe we should avoid this patch and install them via
> setup.py (?)
> 
> - Upstart removal
>   + In this commit you removed some bits from d/rules, the changes seem to
> make sense, but I'd like to make sure you tested it and it indeed does not
> present any unexpected behavior.
> 
> - d/p/update_dhcp_client_ubuntu_supported_versions.patch
>   + Great that you forwarded the patch upstream and it got merged, good job!
>   + A nitpick: in the Forwarded field you should use "yes, <PR_URL>". This is
> to be fully compliant with DEP-3.
> 
> - d/p/fix_systemd_networkd_lease_file_path
>   + The upstream review is ongoing, but considering that you tested those
> changes we can ship it and in the next upload we can apply the fix accepted by
> upstream.
>   + A nitpick: in the Forwarded field you should use "yes, <PR_URL>". This is
> to be fully compliant with DEP-3.
> 
> - d/p/fix_cgroup_v2_mounting_and_systemd_process.patch
>   + It seems that upstream might be implementing this differently. Are you
> confident enough to ship your patch? Is this well tested?
>   + A nitpick: in the Forwarded field you should use "yes, <PR_URL>". This is
> to be fully compliant with DEP-3.
> 
> - Manpage addition
>   + This is great :) but you generated it manually (not during build time),
> I'd say that's fine for now but I'd like you to document how you updated it.
> Maybe create a debian/README.source and explain there how one can update the
> manpage if needed since this is a manual process.
> 
> - DEP-8 tests addition
>   + You do not need to add the "TestSuite: autopkgtest" to d/control. When you
> have the d/tests directory it is known that you have a test suite. So please,
> remove it. Usually we use this field when using autodep8.
>   + d/t/test-correct-cgroup-v2 failed for me locally. There is an issue when
> installing the walinuxagent package:
> 
> The following additional packages will be installed:
>   walinuxagent
> The following NEW packages will be installed:
>   walinuxagent
> 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
> 1 not fully installed or removed.
> Need to get 0 B/268 kB of archives.
> After this operation, 1619 kB of additional disk space will be used.
> Get:1 file:/tmp/autopkgtest.sDoTAQ/binaries  walinuxagent 2.9.1.1-0ubuntu1
> [268 kB]
> Selecting previously unselected package walinuxagent.
> (Reading database ... 33601 files and directories currently installed.)
> Preparing to unpack .../binaries/./walinuxagent.deb ...
> Unpacking walinuxagent (2.9.1.1-0ubuntu1) ...
> dpkg: error processing archive
> /tmp/autopkgtest.sDoTAQ/binaries/./walinuxagent.deb (--unpack):
>  unable to open '/usr/lib/systemd/system/ephemeral-disk-warning.service.dpkg-
> new': No such file or directory
> No apport report written because the error message indicates an issue on the
> local system
> Errors were encountered while processing:
>  /tmp/autopkgtest.sDoTAQ/binaries/./walinuxagent.deb
> needrestart is being skipped since dpkg has failed
> E: Sub-process /usr/bin/dpkg returned an error code (1)
> 
>   This error makes me think if your upstart related changes are correct. Could
> you please double check this? The generated binary seems uninstallable.
> 
> - Build time tests
>   + You probably noticed that there are some test failures. Are you sure any
> of them identified a problem in your patches

Are you testing on an Azure VM?