Merge ~callmepk/ubuntu-release-upgrader:ubuntu/master into ubuntu-release-upgrader:ubuntu/master

[Patrick Wu]

[Balint Reczey (rbalint)]

Please fix /etc/update-motd.d/91-release-upgrade to work as a normal user rather than hacking the executable bit.

review: Needs Fixing

[Patrick Wu (callmepk)]

Just did the fix as requested. Accidentally added a review status, please ignore.

[Balint Reczey (rbalint)]

This bug is not specific to WSL. It can be observed on all Ubuntu installations when running the following command as a normal user:

$ update-motd --show-only
Welcome to Ubuntu 20.04 LTS (GNU/Linux 5.4.0-29-lowlatency x86_64)

 * Documentation: https://help.ubuntu.com
 * Management: https://landscape.canonical.com
 * Support: https://ubuntu.com/advantage

 * MicroK8s passes 9 million downloads. Thank you to all our contributors!

     https://microk8s.io/

15 updates can be installed immediately.
0 of these updates are security updates.
To see these additional updates run: apt list --upgradable

/usr/lib/ubuntu-release-upgrader/release-upgrade-motd: 31: cannot create /var/lib/ubuntu-release-upgrader/release-upgrade-available: Permission denied

Please fix it in a generic way.

[Patrick Wu (callmepk)]

Just update the fix as requested. Righ now I tired to skip executing when it is using a non-root user

[Balint Reczey (rbalint)]

Thanks.
IMO it would be better to show the information when it is present cached, but most likely the cache would be absent on WSL anyway.

Please squash the commits to clean the history, then it will be OK.

[Balint Reczey (rbalint)]

review: Needs Fixing

[Patrick Wu (callmepk)]

Thanks!
I have squashed the commits

[Balint Reczey (rbalint)]

@callmepkg would you like update that commit message, too?

[Patrick Wu (callmepk)]

Thanks and updated

[Balint Reczey (rbalint)]

review: Approve

[Brian Murray (brian-murray)]

$EUID is not set in dash, which is what provides /bin/sh in Ubuntu, so this ended up causing an autopkgtest failure for update-motd as 91-release-upgrades uses /bin/sh. I've sorted this out now but thought it was worth mentioning.

[Patrick Wu (callmepk)]

Hi Brian Murray,

Thanks for the information, and thank you for solving the issue. This also had the same issue in the backported version to focal, could you help me on that? Thanks and sorry for the hassle

[Brian Murray (brian-murray)]

There is a new version in the -proposed repository for focal which could use verification. Please see the relevant bug report for details.

diff --git a/debian/91-release-upgrade b/debian/91-release-upgrade
index f00f489..95fe2ae 100755
--- a/debian/91-release-upgrade
+++ b/debian/91-release-upgrade
@@ -4,6 +4,12 @@
 if [ "$(lsb_release -sd | cut -d' ' -f4)" = "(development" ]; then
     exit 0
 fi
+
+# if it is non-root user, skip
+if [ "$EUID" -ne 0 ]; then
+    exit 0
+fi
+
 if [ -x /usr/lib/ubuntu-release-upgrader/release-upgrade-motd ]; then
     exec /usr/lib/ubuntu-release-upgrader/release-upgrade-motd
 fi