Merge lp:~cairo-dock-team/cairo-dock-plug-ins/menus_workaround into lp:~cairo-dock-team/cairo-dock-plug-ins/plug-ins
Status: | Merged |
---|---|
Merged at revision: | 2416 |
Proposed branch: | lp:~cairo-dock-team/cairo-dock-plug-ins/menus_workaround |
Merge into: | lp:~cairo-dock-team/cairo-dock-plug-ins/plug-ins |
Diff against target: |
183 lines (+87/-8) 4 files modified
GMenu/src/applet-menu.c (+5/-5) Global-Menu/src/applet-notifications.c (+41/-0) Messaging-Menu/src/applet-menu.c (+12/-3) Messaging-Menu/src/applet-notifications.c (+29/-0) |
To merge this branch: | bzr merge lp:~cairo-dock-team/cairo-dock-plug-ins/menus_workaround |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Fabounet | Pending | ||
Review via email:
|
Description of the change
Hello
Here I'm proposing 3 commits... 3 workarounds!
* rev 2413: GMenu: try to load icons sooner
It's hard to know if it's better but I hope so ;) (maybe we can load all menus and icons before but it will take time at startup...)
* rev 2414: Messaging-Menu: removed double entries in the menu and double separators. Yes, it's just a wonderful workaround :D
As you can see... it's a workaround! It's just a hack to fix this (stupid and a bit ugly/annoying) bug. About this bug (double entries/
* rev 2415: Global-Menu: removed double separators in the menu (workaround)
+ removed a wrong error message when we click on the main icon if we don't steal window menus
A bit more ugly to remove these double separators in submenu too... Yes, it's possible :D
Without that we can see that Gedit menu contains a lot of useless separators. (but it's maybe due to appmenu-registrar?)
I know these modifications are not very well but I think it's currently the only solution...
Can I merge it into the trunk? :)
(note that you can use `bzr merge --pull` instead of just `bzr merge` ;) )