Merge lp:~caio1982/capomastro/charm-from-pes-to-os into lp:~ubuntuone-hackers/capomastro/charm

Proposed by Caio Begotti
Status: Merged
Approved by: Daniel Manrique
Approved revision: 72
Merged at revision: 70
Proposed branch: lp:~caio1982/capomastro/charm-from-pes-to-os
Merge into: lp:~ubuntuone-hackers/capomastro/charm
Diff against target: 81 lines (+6/-7)
5 files modified
README (+3/-3)
config.yaml (+1/-1)
files/download-supported-job-types (+1/-1)
hooks/nrpe-external-master-relation-changed (+0/-1)
templates/nrpe_service_file.tmpl (+1/-1)
To merge this branch: bzr merge lp:~caio1982/capomastro/charm-from-pes-to-os
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+272236@code.launchpad.net

Commit message

Update some of the mentions (if not all :-]) to the old PES team, to reflect the changes needed to put Capomastro under the OS umbrella. The spec will also be updated in a different MR.

Description of the change

Update some of the mentions (if not all :-]) to the old PES team, to reflect the changes needed to put Capomastro under the OS umbrella. The spec will also be updated in a different MR.

The repository still need to be set up accordingly by IS as they have permission to change owners directly, we don't.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, my only comment is whether we need a replacement for this line which was removed:

export t_nagios_project="PES"

but we could fix it later if it gives trouble.

review: Approve
Revision history for this message
Caio Begotti (caio1982) wrote :

Nope, that was just extra info used in the description of the check.

On Tue, Sep 29, 2015 at 10:20 AM, Daniel Manrique <
<email address hidden>> wrote:

> Review: Approve
>
> +1, my only comment is whether we need a replacement for this line which
> was removed:
>
> export t_nagios_project="PES"
>
> but we could fix it later if it gives trouble.
> --
>
> https://code.launchpad.net/~caio1982/capomastro/charm-from-pes-to-os/+merge/272236
> You are the owner of lp:~caio1982/capomastro/charm-from-pes-to-os.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2014-11-06 16:21:43 +0000
3+++ README 2015-09-24 12:59:08 +0000
4@@ -13,7 +13,7 @@
5
6 * Trusty 14.04, as it's the minimal supported version
7 * Access to lp:bygmester (ideally, not absolutely required though)
8-* Access to the PES CE's PPA ppa:ce-infrastructure/capomastro
9+* Access to the repository ppa:ubuntuone-hackers/capomastro
10
11 Grabbing charms
12 ---------------
13@@ -22,7 +22,7 @@
14 $ mkdir -p charms/trusty; cd charms/trusty
15
16 Check out Capomastro's charm:
17-$ bzr branch lp:~ce-infrastructure/capomastro/charm capomastro
18+$ bzr branch lp:~ubuntuone-hackers/capomastro/charm capomastro
19
20 Modified Jenkins' charm now:
21 $ bzr branch lp:~caio1982/charms/trusty/jenkins-ce-charm/trunk jenkins
22@@ -38,7 +38,7 @@
23 manual tweaking as adding private PPAs via apt-add-repository is not support yet. So
24 please edit and do it manually in the hooks/install script.
25
26-$ apt-add-repository ppa:ce-infrastructure/capomastro
27+$ apt-add-repository ppa:ubuntuone-hackers/capomastro
28
29 If you need to change/add SSH keypairs or different jobs, put them inside the files dir, like
30 the following example tree. Inside the jobs dir you'd put the checkouts of all jobs types
31
32=== modified file 'config.yaml'
33--- config.yaml 2015-04-06 12:38:33 +0000
34+++ config.yaml 2015-09-24 12:59:08 +0000
35@@ -57,7 +57,7 @@
36 description: "The superuser e-mail address for eventual notifications"
37 repository:
38 type: string
39- default: "ppa:ce-infrastructure/capomastro"
40+ default: "ppa:ubuntuone-hackers/capomastro"
41 description: "The PPA address or private repository line for apt-add-repository"
42 nagios_context:
43 default: "juju"
44
45=== modified file 'files/download-supported-job-types'
46--- files/download-supported-job-types 2014-10-30 17:14:41 +0000
47+++ files/download-supported-job-types 2015-09-24 12:59:08 +0000
48@@ -2,7 +2,7 @@
49
50 _TREE="bygmester/jobs"
51 _TYPES="rootfs tarball image-puller android-barajas android"
52-_PROJ="~ce-infrastructure/bygmester"
53+_PROJ="~ubuntuone-hackers/bygmester"
54
55 mkdir -p ${_TREE}
56 pushd ${_TREE} > /dev/null
57
58=== modified file 'hooks/nrpe-external-master-relation-changed'
59--- hooks/nrpe-external-master-relation-changed 2015-02-19 00:59:50 +0000
60+++ hooks/nrpe-external-master-relation-changed 2015-09-24 12:59:08 +0000
61@@ -12,7 +12,6 @@
62 # that possibly no one would need to change, hence we'll
63 # have a less cluttered config.yaml file
64 export t_nagios_context="$(config-get nagios_context)"
65- export t_nagios_project="PES"
66 export t_nagios_servicegroup="$t_nagios_context"
67 export t_nagios_hostname="${t_nagios_context}-${unit_name//\//-}"
68
69
70=== modified file 'templates/nrpe_service_file.tmpl'
71--- templates/nrpe_service_file.tmpl 2015-02-19 00:59:50 +0000
72+++ templates/nrpe_service_file.tmpl 2015-09-24 12:59:08 +0000
73@@ -2,7 +2,7 @@
74 define service {
75 use active-service
76 host_name ${t_nagios_hostname}
77- service_description ${t_nagios_hostname} ${t_nagios_project} ${t_nagios_context} ${t_nagios_service_description}
78+ service_description ${t_nagios_hostname} ${t_nagios_context} ${t_nagios_service_description}
79 check_command check_nrpe!${t_nagios_command_name}
80 servicegroups ${t_nagios_servicegroup},
81 }

Subscribers

People subscribed via source and target branches