Merge lp:~cablespaghetti/gwibber/retweetbugfix into lp:gwibber

Proposed by Sam Weston
Status: Merged
Merge reported by: Ryan Paul
Merged at revision: not available
Proposed branch: lp:~cablespaghetti/gwibber/retweetbugfix
Merge into: lp:gwibber
Diff against target: 40 lines
3 files modified
gwibber/actions.py (+1/-1)
gwibber/client.py (+4/-2)
ui/templates/defaultcss.mako (+0/-1)
To merge this branch: bzr merge lp:~cablespaghetti/gwibber/retweetbugfix
Reviewer Review Type Date Requested Status
gwibber-committers Pending
Review via email: mp+13866@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sam Weston (cablespaghetti) wrote :

The changes fix this bug:
https://bugs.launchpad.net/gwibber/+bug/404939

However I only have a twitter account and so can only guarantee that the changes work with twitter. That said, I haven't changed anything that should affect other services.

I hope I've done this right as I have no prior experience with bzr or launchpad.

478. By Sam Weston <sam@mal>

Fix for display pictures not showing in ubuntu (bug 454526)

479. By Sam Weston <sam@mal>

Merge from lp:gwibber 478

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gwibber/actions.py'
2--- gwibber/actions.py 2009-09-24 15:06:26 +0000
3+++ gwibber/actions.py 2009-10-31 21:53:09 +0000
4@@ -55,7 +55,7 @@
5 @classmethod
6 def action(self, w, client, msg):
7 if not client.preferences["global_retweet"]:
8- client.reply_target = msg
9+ client.reply_target = None
10 client.target_bar.set_account(msg.account)
11 client.target_bar.show()
12
13
14=== modified file 'gwibber/client.py'
15--- gwibber/client.py 2009-10-22 19:37:29 +0000
16+++ gwibber/client.py 2009-10-31 21:53:09 +0000
17@@ -731,8 +731,10 @@
18
19 if self.reply_target:
20 args.append("message://" + self.reply_target.gwibber_path)
21-
22- self.send(self.target_bar.get_account(), args, True)
23+ self.send(self.target_bar.get_account(), args, True)
24+ else:
25+ self.send(self.target_bar.get_account(), [text])
26+
27 self.reply_target = None
28 self.target_bar.hide()
29
30
31=== modified file 'ui/templates/defaultcss.mako'
32--- ui/templates/defaultcss.mako 2009-10-01 03:36:53 +0000
33+++ ui/templates/defaultcss.mako 2009-10-31 21:53:09 +0000
34@@ -48,7 +48,6 @@
35 -webkit-background-size: 100% 100%;
36 background-image: url('');
37 background-repeat: no-repeat;
38- -webkit-border-radius: 3px;
39 -webkit-box-reflect:below 0px -webkit-gradient(linear, left top, left bottom, from(transparent), color-stop(0.6, transparent), to(rgba(0,0,0, 0.6)));
40 }
41

Subscribers

People subscribed via source and target branches