Merge lp:~c-lobrano/ubuntu-themes/fix-1704745 into lp:ubuntu-themes

Proposed by Carlo Lobrano on 2017-07-18
Status: Rejected
Rejected by: Marco Trevisan (Treviño) on 2017-10-23
Proposed branch: lp:~c-lobrano/ubuntu-themes/fix-1704745
Merge into: lp:ubuntu-themes
Diff against target: 61 lines (+38/-1)
2 files modified
Ambiance/gtk-3.20/apps/libreoffice.css (+19/-1)
Radiance/gtk-3.20/apps/libreoffice.css (+19/-0)
To merge this branch: bzr merge lp:~c-lobrano/ubuntu-themes/fix-1704745
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) 2017-07-18 Needs Fixing on 2017-08-22
Review via email: mp+327584@code.launchpad.net

Commit message

Fix Libreoffice close button style

In both Ambiance and Radiance, the Libreoffice's close button
on the tob right corner (below the windows's close button) has
a different color respect the menu bar in which is placed.

This commit fixes close button color and background in normal,
unfocused and hover state.

To post a comment you must log in.
Marco Trevisan (Treviño) (3v1n0) wrote :

I'm sorry we can't apply this as it's too generic and it breaks (for example) gitg commit message.

I don't think we can't do much here until libreoffice doesn't add a (parent, at least) widget with its class name

review: Needs Fixing
Carlo Lobrano (c-lobrano) wrote :

Oh, I see, that's a pity

Adolfo Jayme (fitojb) wrote :

Is the LibreOffice issue reported upstream? If not, please do :) See https://bugs.documentfoundation.org/show_bug.cgi?id=GTK3

Carlo Lobrano (c-lobrano) wrote :

Hi Adolfo,

it doesn't seem necessary anymore, it is not reproducible anymore in LibreOffice 5.4

Marco Trevisan (Treviño) (3v1n0) wrote :

I think the main issue here is still the fact that the selector is too general and also other apps might be affected by change.

Carlo Lobrano (c-lobrano) wrote :

I see, thanks for the new review anyway. If I'll reproduce the bug on the new LibreOffice 5.4, I'll open a bug upstream, then.

Unmerged revisions

556. By Carlo Lobrano on 2017-08-30

Fix LibreOffice close button style

improved previous fix, using a rule more specific that (should)
avoid to break other applications (e.g. gitg).

This commit makes the background and foreground color of the
LibreOffice's close button on the top right corner matching
with the adiacent menubar.

Fixes LP:1704745

555. By Carlo Lobrano on 2017-08-30

Update from mainline

554. By Carlo Lobrano on 2017-07-18

Fix Libreoffice close button style

In both Ambiance and Radiance, the Libreoffice's close button
on the tob right corner (below the windows's close button) has
a different color respect the menu bar in which is placed.

This commit fixes close button color and background in normal,
unfocused and hover state.

Fixes LP:1704745

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.20/apps/libreoffice.css'
2--- Ambiance/gtk-3.20/apps/libreoffice.css 2016-10-06 18:53:39 +0000
3+++ Ambiance/gtk-3.20/apps/libreoffice.css 2017-08-30 14:15:00 +0000
4@@ -1,7 +1,7 @@
5 .libreoffice-toolbar {
6 background-image: none;
7 border: none;
8- box-shadow: none;
9+ box-shadow: none;
10 }
11 .libreoffice-toolbar button:hover {
12 background-image: -gtk-gradient (linear, left top, left bottom,
13@@ -17,3 +17,21 @@
14 to (shade (@selected_bg_color, 1.28)));
15 border-image-source: url("assets/button-active-hover.png");
16 }
17+
18+/* 'close' button */
19+window > decoration ~ grid.horizontal > grid.horizontal {
20+ background-color: @dark_bg_color;
21+}
22+
23+window > grid > grid > menubar + button.flat.small-button {
24+ background-color: @dark_bg_color;
25+ color: @dark_fg_color;
26+}
27+
28+window > grid > grid > menubar + button.flat.small-button:backdrop {
29+ color: @theme_unfocused_fg_color;
30+}
31+
32+window > grid > grid > menubar + button.flat.small-button:hover {
33+ color: @dark_bg_color;
34+}
35
36=== modified file 'Radiance/gtk-3.20/apps/libreoffice.css'
37--- Radiance/gtk-3.20/apps/libreoffice.css 2016-10-06 18:53:39 +0000
38+++ Radiance/gtk-3.20/apps/libreoffice.css 2017-08-30 14:15:00 +0000
39@@ -17,3 +17,22 @@
40 to (shade (@selected_bg_color, 1.28)));
41 border-image-source: url("assets/button-active-hover.png");
42 }
43+
44+/* 'close' button */
45+window > decoration ~ grid.horizontal > grid.horizontal {
46+ background-color: @dark_bg_color;
47+}
48+
49+window > grid > grid > menubar + button.flat.small-button {
50+ background-color: @dark_bg_color;
51+ color: @dark_fg_color;
52+}
53+
54+window > grid > grid > menubar + button.flat.small-button:backdrop {
55+ color: @theme_unfocused_fg_color;
56+}
57+
58+window > grid > grid > menubar + button.flat.small-button:hover {
59+ background-color: @dark_bg_color;
60+ color: @dark_fg_color;
61+}

Subscribers

People subscribed via source and target branches