Merge lp:~c-lobrano/ubuntu-themes/fix-1701512 into lp:ubuntu-themes

[Carlo Lobrano]

Fixes support GtkTreeView separators

Added 2px min-height to treeview's separator in order to avoid vertical glitches
Added also a @border color to separator itself.

This patch is intended to fix lp:1701512 Ambiance and Radiance Gtk theme do not properly support GtkTreeView separators

[Daniel van Vugt (vanvugt)]

Please remember to update Radiance/* with the same if required.

[Carlo Lobrano (c-lobrano)]

Sure. I will update the patch then

[lp:~c-lobrano/ubuntu-themes/fix-1701512]

555. By Carlo Lobrano on 2017-07-10

Porting from Ambiance to Radiance

Ported fix for lp:1701512 from Ambiance to Radiance, which is affected as well.

[Marco Trevisan (Treviño) (3v1n0)]

Looks good, as for the gray color you chose, could you instead use one of the defined colors we have in gtk-main.css?

So that we reduce the usage of custom colors

[Carlo Lobrano (c-lobrano)]

Do you think that @borders would be ok? I'm trying to find a color with a
suitable name

On 10 August 2017 at 16:07, Marco Trevisan (Treviño) <[e-mail]> wrote:

> Looks good, as for the gray color you chose, could you instead use one of
> the defined colors we have in gtk-main.css?
>
> So that we reduce the usage of custom colors
> --
> https://code.launchpad.net/~c-lobrano/ubuntu-themes/fix-
> 1701512/+merge/327057
> You are the owner of lp:~c-lobrano/ubuntu-themes/fix-1701512.
>

[lp:~c-lobrano/ubuntu-themes/fix-1701512]

556. By Carlo Lobrano on 2017-08-20

Replaced custom color with one from gtk-main

As per code review, this will reduce the usage of custom colors

[Carlo Lobrano (c-lobrano)]

I though it would be safe to discuss on the code directly and then I pushed the change. Let me know if this is OK

[Marco Trevisan (Treviño) (3v1n0)]

Looks good, thanks

review: Approve

[Carlo Lobrano (c-lobrano)]

Great! Thanks

[Adolfo Jayme Barrientos (fitojb)]

Is anything blocking the merging of this patch?

=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
--- Ambiance/gtk-3.20/gtk-widgets.css	2017-06-09 08:46:35 +0000
+++ Ambiance/gtk-3.20/gtk-widgets.css	2017-08-20 16:54:36 +0000
@@ -1698,6 +1698,11 @@
     color: shade (@bg_color, 0.92);
 }
 
+treeview.view.separator {
+    min-height: 2px;
+    color: @borders;
+}
+
 separator.horizontal {
     border-width: 1px 0 1px 0;
 }

=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
--- Radiance/gtk-3.20/gtk-widgets.css	2017-06-09 08:46:35 +0000
+++ Radiance/gtk-3.20/gtk-widgets.css	2017-08-20 16:54:36 +0000
@@ -1697,6 +1697,11 @@
     color: shade (@bg_color, 0.92);
 }
 
+treeview.view.separator {
+    min-height: 2px;
+    color: @borders;
+}
+
 separator.horizontal {
     border-width: 1px 0 1px 0;
 }