Merge lp:~c-lobrano/ubuntu-themes/bug-1708141 into lp:ubuntu-themes

Proposed by Carlo Lobrano
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 554
Merged at revision: 562
Proposed branch: lp:~c-lobrano/ubuntu-themes/bug-1708141
Merge into: lp:ubuntu-themes
Diff against target: 57 lines (+36/-0)
2 files modified
Ambiance/gtk-3.20/gtk-widgets.css (+18/-0)
Radiance/gtk-3.20/gtk-widgets.css (+18/-0)
To merge this branch: bzr merge lp:~c-lobrano/ubuntu-themes/bug-1708141
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Ubuntu Artwork Packagers Pending
Review via email: mp+328927@code.launchpad.net

Commit message

Added support for vertically linked buttons

Currently both Ambiance and Radiance themes use horizontal
linked button style for even for the vertically linked buttons.

This patch fixes this introducing css styling for verical
linked button first, last and only child.

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

I've tested this and it look goods to me. But I'll defer to Marco for a proper review.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ack!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
2--- Ambiance/gtk-3.20/gtk-widgets.css 2017-06-09 08:46:35 +0000
3+++ Ambiance/gtk-3.20/gtk-widgets.css 2017-08-11 17:40:57 +0000
4@@ -277,6 +277,24 @@
5 box-shadow: none;
6 }
7
8+.linked.vertical button:first-child {
9+ border-image-width: 10px 10px 0 10px;
10+ border-width: 1px;
11+ border-radius: 0;
12+}
13+
14+.linked.vertical button:only-child {
15+ border-image-width: 10px;
16+ border-width: 1px;
17+ border-radius: 0;
18+}
19+
20+.linked.vertical button:last-child {
21+ border-image-width: 0 10px 10px 10px;
22+ border-width: 1px;
23+ border-radius: 0;
24+}
25+
26 *:link,
27 *:visited {
28 color: @link_color;
29
30=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
31--- Radiance/gtk-3.20/gtk-widgets.css 2017-06-09 08:46:35 +0000
32+++ Radiance/gtk-3.20/gtk-widgets.css 2017-08-11 17:40:57 +0000
33@@ -276,6 +276,24 @@
34 box-shadow: none;
35 }
36
37+.linked.vertical button:first-child {
38+ border-image-width: 10px 10px 0 10px;
39+ border-width: 1px;
40+ border-radius: 0;
41+}
42+
43+.linked.vertical button:only-child {
44+ border-image-width: 10px;
45+ border-width: 1px;
46+ border-radius: 0;
47+}
48+
49+.linked.vertical button:last-child {
50+ border-image-width: 0 10px 10px 10px;
51+ border-width: 1px;
52+ border-radius: 0;
53+}
54+
55 *:link,
56 *:visited {
57 color: @link_color;

Subscribers

People subscribed via source and target branches