Merge lp:~bzr/bzr/iter-changes-excluding into lp:~bzr/bzr/trunk-old
Proposed by
Ian Clatworthy
Status: | Rejected |
---|---|
Rejected by: | Ian Clatworthy |
Proposed branch: | lp:~bzr/bzr/iter-changes-excluding |
Merge into: | lp:~bzr/bzr/trunk-old |
Diff against target: | 116 lines |
To merge this branch: | bzr merge lp:~bzr/bzr/iter-changes-excluding |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Needs Fixing | ||
Review via email: mp+6674@code.launchpad.net |
To post a comment you must log in.
Another building block for faster selective file commit.
Note: 'exclude_files' will probably become a parameter to iter_changes() in the medium to long term. Implementing it efficiently across the half dozen implementations of iter_changes() is quite a bit of work though and not without risk. In comparison, this decorator is much simpler to code and test. It is also useful in its own right and, above all, helps deliver a large performance gain for faster selective commit real soon now.