I really wonder if this should be in "bzrlib/preview_tree.py". Not that you have to do that.
I noticed you didn't add "bzrlib/tests/test_ls.py". Since the code is now refactored, it would be nice if most of the 'blackbox/tests_ls.py' was actually done as whitebox tests. Again, not required, but if you at least added the test file and some very basic tests, it would be a place that could be obviously expanded later.
So overall, I think it is worth landing something like this.
Sorry, I hit 'Save' before I was done.
=== modified file 'bzrlib/ transform. py'
I really wonder if this should be in "bzrlib/ preview_ tree.py" . Not that you have to do that.
I noticed you didn't add "bzrlib/ tests/test_ ls.py". Since the code is now refactored, it would be nice if most of the 'blackbox/ tests_ls. py' was actually done as whitebox tests. Again, not required, but if you at least added the test file and some very basic tests, it would be a place that could be obviously expanded later.
So overall, I think it is worth landing something like this.