Code review comment for lp:~bzr/bzr/faster-branch-notree

Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> Ian Clatworthy has proposed merging lp:~bzr/bzr/faster-branch-notree into lp:bzr.

I would really prefer not to fix it this way. It is coded this way
because we expect iter_references to be efficient. To make it efficient
with RevisionTrees, we just need to exit early when the underlying
repository doesn't support tree-references, as we already do with
WorkingTree4.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoT1isACgkQ0F+nu1YWqI05bgCdELsR0goUTvR+kqGoiZsPdX0V
alkAn2Az6NsCE+SiWZIy//tgsJe87Oc2
=Z30H
-----END PGP SIGNATURE-----

« Back to merge proposal