Merge lp:~bzoltan/ubuntu-weather-app/ensure_visible into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Zoltan Balogh
Status: Rejected
Rejected by: Alan Pope 🍺🐧🐱 πŸ¦„
Proposed branch: lp:~bzoltan/ubuntu-weather-app/ensure_visible
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 12 lines (+1/-1)
1 file modified
tests/autopilot/ubuntu_weather_app/tests/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~bzoltan/ubuntu-weather-app/ensure_visible
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Alan Pope 🍺🐧🐱 πŸ¦„ Pending
Review via email: mp+242981@code.launchpad.net

Commit message

Replace deprecated and private _show_if_not_visible() with the public ensure_visible()

Description of the change

Replace deprecated and private _show_if_not_visible() with the public ensure_visible()

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

389. By Zoltan Balogh on 2014-11-26

Replace deprecated and private _show_if_not_visible() with the public ensure_visible()

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/autopilot/ubuntu_weather_app/tests/__init__.py'
--- tests/autopilot/ubuntu_weather_app/tests/__init__.py 2014-09-04 16:21:49 +0000
+++ tests/autopilot/ubuntu_weather_app/tests/__init__.py 2014-11-26 22:14:14 +0000
@@ -136,7 +136,7 @@
136 name.136 name.
137137
138 """138 """
139 self._show_if_not_visible()139 self.ensure_visible()
140140
141 button = self._get_action_button(action_object_name)141 button = self._get_action_button(action_object_name)
142 time.sleep(2)142 time.sleep(2)

Subscribers

People subscribed via source and target branches