Merge lp:~bzoltan/ubuntu-calendar-app/lp_1351024_workaround into lp:ubuntu-calendar-app

Proposed by Zoltan Balogh on 2014-08-08
Status: Rejected
Rejected by: Nekhelesh Ramananthan on 2014-09-24
Proposed branch: lp:~bzoltan/ubuntu-calendar-app/lp_1351024_workaround
Merge into: lp:ubuntu-calendar-app
Diff against target: 12 lines (+1/-1)
1 file modified
NewEvent.qml (+1/-1)
To merge this branch: bzr merge lp:~bzoltan/ubuntu-calendar-app/lp_1351024_workaround
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan 2014-08-08 Disapprove on 2014-09-24
Review via email: mp+230095@code.launchpad.net

Commit message

Use the JS PickerPanel to work around the #1351024

Description of the change

Use the JS PickerPanel to work around the #1351024

To post a comment you must log in.
Timo Jyrinki (timo-jyrinki) wrote :

Looks identical to my branch, not working at least yet with the current UITK proposal:
https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1351024/comments/20

Nekhelesh Ramananthan (nik90) wrote :

I believe we won't be needing this any longer since the date picker works as expected in calendar. I am thereby rejecting this MP.

review: Disapprove

Unmerged revisions

387. By Zoltan Balogh on 2014-08-08

Use the JS PickerPanel to work around the #1351024

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NewEvent.qml'
2--- NewEvent.qml 2014-08-01 14:28:34 +0000
3+++ NewEvent.qml 2014-08-08 12:08:51 +0000
4@@ -276,7 +276,7 @@
5
6 function openDatePicker (element, caller, callerProperty, mode) {
7 element.highlighted = true;
8- var picker = PickerPanel.openDatePicker(caller, callerProperty, mode);
9+ var picker = PickerPanelWorkaround.openDatePicker(caller, callerProperty, mode);
10 if (!picker) return;
11 picker.closed.connect(function () {
12 element.highlighted = false;

Subscribers

People subscribed via source and target branches

to status/vote changes: