Merge lp:~bzoltan/qtcreator-plugin-ubuntu/fix_1324555 into lp:qtcreator-plugin-ubuntu

Proposed by Zoltan Balogh
Status: Rejected
Rejected by: Zoltan Balogh
Proposed branch: lp:~bzoltan/qtcreator-plugin-ubuntu/fix_1324555
Merge into: lp:qtcreator-plugin-ubuntu
Diff against target: 0 lines
To merge this branch: bzr merge lp:~bzoltan/qtcreator-plugin-ubuntu/fix_1324555
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Benjamin Zeller Approve
Review via email: mp+222622@code.launchpad.net

Commit message

Use unknown as developed ID when there is no LP ID available (LP: #1324555)

Description of the change

Use unknown as developed ID when there is no LP ID available (LP: #1324555)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
184. By Zoltan Balogh

Use unknown as developed ID when there is no LP ID available (LP: #1324555)

185. By Zoltan Balogh

Use unknown as developed ID when there is no LP ID available (LP: #1324555)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

Added some inline comments

186. By Zoltan Balogh

bzr whoami does not handle exceptions well, so code is changed in qtc_bzr_info

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
187. By Zoltan Balogh

remove possible conflict with and other MR

Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

ok

review: Approve
188. By Zoltan Balogh

Fix merge conflict

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

188. By Zoltan Balogh

Fix merge conflict

187. By Zoltan Balogh

remove possible conflict with and other MR

186. By Zoltan Balogh

bzr whoami does not handle exceptions well, so code is changed in qtc_bzr_info

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: