Merge lp:~bzoltan/qtcreator-plugin-ubuntu/fix_1274265 into lp:qtcreator-plugin-ubuntu

Proposed by Zoltan Balogh
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 70
Merged at revision: 73
Proposed branch: lp:~bzoltan/qtcreator-plugin-ubuntu/fix_1274265
Merge into: lp:qtcreator-plugin-ubuntu
Diff against target: 17 lines (+2/-2)
1 file modified
src/ubuntu/ubuntupackagingwidget.cpp (+2/-2)
To merge this branch: bzr merge lp:~bzoltan/qtcreator-plugin-ubuntu/fix_1274265
Reviewer Review Type Date Requested Status
Benjamin Zeller Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+204083@code.launchpad.net

Commit message

Remove forced update of the maintainer in the manifest.json (Fixes: #1274265)

Description of the change

This single line changes seems to fix #1274265

The maintainer field of the manifest.json should not be forced to the bzr identity.

It might be better idea to offer to the developer to choose from various identity.

To post a comment you must log in.
Revision history for this message
Zoltan Balogh (bzoltan) wrote :
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

Looks goods , ready to merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntu/ubuntupackagingwidget.cpp'
2--- src/ubuntu/ubuntupackagingwidget.cpp 2014-01-28 18:30:42 +0000
3+++ src/ubuntu/ubuntupackagingwidget.cpp 2014-01-30 19:25:56 +0000
4@@ -280,11 +280,11 @@
5
6 void UbuntuPackagingWidget::load_manifest(QString fileName) {
7 m_manifest.load(fileName,m_projectName);
8- m_manifest.setMaintainer(m_bzr.whoami());
9+ // Commented out for bug #1274265 https://bugs.launchpad.net/qtcreator-plugin-ubuntu/+bug/1274265
10+ //m_manifest.setMaintainer(m_bzr.whoami());
11 QString userName = m_bzr.launchpadId();
12 if (userName.isEmpty()) userName = QLatin1String(Constants::USERNAME);
13 m_projectName.replace(QLatin1String(Constants::UNDERLINE),QLatin1String(Constants::DASH));
14-
15 // Commented out for bug #1219948 - https://bugs.launchpad.net/qtcreator-plugin-ubuntu/+bug/1219948
16 //m_manifest.setName(QString(QLatin1String("com.ubuntu.developer.%0.%1")).arg(userName).arg(m_projectName));
17 }

Subscribers

People subscribed via source and target branches

to all changes: