Merge lp:~bzoltan/click/extend_1410_fw into lp:click

[Zoltan Balogh]

Added a set of APIs to the 14.10 frameworks

Added a set of APIs to the 14.10 frameworks

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:440
http://jenkins.qa.ubuntu.com/job/click-ci/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/8/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/8/rebuild

review: Needs Fixing (continuous-integration)

[Colin Watson (cjwatson)]

Please keep entries sorted within each list. (I think there's one violation of that right now, which you can fix.)

You've introduced a tab for indentation, as reported by pep8 via Jenkins. Please fix.

You've introduced at least three duplicate items ("libqt5sensors-dev:TARGET", "qmlscene:TARGET", and "qt5-default:TARGET"). Please remove these. Sorting would make it easier to see if there are any more of these.

It's unnecessary to explicitly expand out dependencies, including but not limited to libcontent-hub0 (a dependency of libcontent-hub-dev) or libqt5script5 (a dependency of qtscript5-dev). Please remove these. The less noise there is in this list, the easier it will be to see what's going on. In general this patch seems to introduce a great deal of noise and it's quite difficult to work out what it's meant to actually do. Try to keep your patches minimal and then it's easier to review them.

The change of "qtdeclarative5-dev-tools" to "qtdeclarative5-dev-tools:TARGET" seems dubious. qtdeclarative5-tools is Multi-Arch: foreign, which per the multiarch spec means that it may be installed from any architecture and provides only architecture-independent interfaces. Could you please explain this change? If the architecture of qtdeclarative5-dev-tools matters, then I would argue that its Multi-Arch: foreign annotation is wrong.

Could you please confirm that each and every new item in this list is also part of the sdk-libs-dev seed? The long-term intention is for this manually-maintained list in "click chroot" to be replaced by simply installing ubuntu-sdk-libs-dev:TARGET; there are some problems at the moment that have made it difficult to do this in practice, but we should make sure that we aren't drifting further away from that goal.

review: Needs Fixing

[lp:~bzoltan/click/extend_1410_fw]

441. By Zoltan Balogh on 2014-07-22

Remove tab indentation

442. By Zoltan Balogh on 2014-07-22

Sort 14.10 fw package list

443. By Zoltan Balogh on 2014-07-22

Remove duplications from the 14.10 fw package list

444. By Zoltan Balogh on 2014-07-22

Remove unnecessary TARGET for qtdeclarative5-dev-tools in 14.10 fw package list

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:443
http://jenkins.qa.ubuntu.com/job/click-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/9/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/9/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:444
http://jenkins.qa.ubuntu.com/job/click-ci/10/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/10/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/10/rebuild

review: Approve (continuous-integration)

[lp:~bzoltan/click/extend_1410_fw]

445. By Zoltan Balogh on 2014-07-22

Remove packages from the 14.10 fw what are pulled by any package already on the list

[Zoltan Balogh (bzoltan)]

Yes, I can confirm that all these new packages are from the ubuntu-sdk-libs-dev and ubuntu-sdk-libs.

I made a short shell script to loop through the framework package list and check the rdepends for each package if any of the listed package would pull. There were many. Qt's dependency tree is complex, deep and not easy to follow. Some of the packages have strange dependencies. For example if I would eliminate all redundancy in this list I would end up removing the UITK because the qtdeclarative5-ubuntu-telephony-phonenumber0.1 pulls it. What would not sound right to me.

Anyhow, the list is more logical now.

And yes, the best solution would be to simple pull ubuntu-sdk-libs-dev:TARGET and maintain only the ubuntu-touch.

The present solution I find a bit confusing as we have double definition of the frameworks and neither of them are complete or stable.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:445
http://jenkins.qa.ubuntu.com/job/click-ci/11/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/11/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/11
        deb: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/11/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/11/rebuild

review: Needs Fixing (continuous-integration)

[Michael Vogt (mvo)]

I'm working on the goal to have "apt-get install ubuntu-sdk-libs-dev:TARGET" and I'm making some good progress here.

[Zoltan Balogh (bzoltan)]

> I'm working on the goal to have "apt-get install ubuntu-sdk-libs-dev:TARGET"
> and I'm making some good progress here.

That is great. In the meantime it would be good to get these APIs in to the default chroots.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:446
http://jenkins.qa.ubuntu.com/job/click-ci/12/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/12
        deb: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/12/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/12/rebuild

review: Approve (continuous-integration)

[Michael Vogt (mvo)]

Thanks for this branch and for the updates.

I looked over the seed and all new packages are also part of the sdk-libs or sdk-libs-dev seed. So thats all good.

One question: There is a commit r446 that looks empty, was this maybe a accidental commit? If so, a uncommit would be nice. Otherwise it looks good to me.

review: Approve

[Zoltan Balogh (bzoltan)]

Jenkins fell on its face on 2014-07-22. The empty commit is a gentle kick to restart the build.

I am happy to uncomit.

Thanks for reviewing!

[lp:~bzoltan/click/extend_1410_fw]

446. By Zoltan Balogh on 2014-08-04

Install the UITK docs with the relevant fw API documentation to the chroots

447. By Zoltan Balogh on 2014-08-04

remove line duplication

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:447
http://jenkins.qa.ubuntu.com/job/click-ci/13/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/13
        deb: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/13/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/13/rebuild

review: Approve (continuous-integration)

[lp:~bzoltan/click/extend_1410_fw]

448. By Zoltan Balogh on 2014-08-05

Add the Setting API from the Qt.Labs

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:448
http://jenkins.qa.ubuntu.com/job/click-ci/14/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-amd64-ci/14
    SUCCESS: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/14
        deb: http://jenkins.qa.ubuntu.com/job/click-utopic-armhf-ci/14/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/click-ci/14/rebuild

review: Approve (continuous-integration)

[Colin Watson (cjwatson)]

This mostly looks good now, thanks. The result of this change includes dropping qt5-default:armhf from the chroot (verified empirically), which seems unlikely to be intentional since it's in ubuntu-sdk-libs-dev. I'll fix that up immediately after merging onto lp:click/devel (our bulk staging branch), though.

review: Approve

=== modified file 'click/chroot.py'
--- click/chroot.py	2014-07-03 11:03:24 +0000
+++ click/chroot.py	2014-08-05 11:49:17 +0000
@@ -73,6 +73,7 @@
         "qtscript5-dev:TARGET",
         "qtsensors5-dev:TARGET",
         "qttools5-dev:TARGET",
+        "ubuntu-ui-toolkit-doc",
         ],
     "ubuntu-sdk-14.04": [
         "cmake",
@@ -94,27 +95,52 @@
         "qtsensors5-dev:TARGET",
         "qttools5-dev:TARGET",
         "qttools5-dev-tools:TARGET",
+        "ubuntu-ui-toolkit-doc",
         ],
     "ubuntu-sdk-14.10": [
         "cmake",
-        "libqt5svg5-dev:TARGET",
-        "libqt5webkit5-dev:TARGET",
-        "libqt5xmlpatterns5-dev:TARGET",
-        "libunity-scopes-dev:TARGET",
-        # bug #1316930, needed for autopilot
-        "python3",
-        "qmlscene:TARGET",
-        "qt3d5-dev:TARGET",
-        "qt5-default:TARGET",
-        "qtbase5-dev:TARGET",
-        "qtdeclarative5-dev:TARGET",
-        "qtdeclarative5-dev-tools",
-        "qtlocation5-dev:TARGET",
-        "qtmultimedia5-dev:TARGET",
-        "qtscript5-dev:TARGET",
+        "libcontent-hub-dev:TARGET",
+        "libqt5keychain0:TARGET",
         "libqt5sensors5-dev:TARGET",
+        "libqt5svg5-dev:TARGET",
+        "libqt5webkit5-dev:TARGET",
+        "libqt5xmlpatterns5-dev:TARGET",
+        "libunity-scopes-dev:TARGET",
+        # bug #1316930, needed for autopilot
+        "python3",
+        "qml-module-qt-labs-settings:TARGET",
+        "qml-module-qtmultimedia:TARGET",
+        "qml-module-qtquick-layouts:TARGET",
+        "qml-module-qtsensors:TARGET",
+        "qml-module-qtwebkit:TARGET",
+        "qmlscene:TARGET",
+        "qt3d5-dev:TARGET",
+        "qtdeclarative5-accounts-plugin:TARGET",
+        "qtdeclarative5-dev-tools",
+        "qtdeclarative5-folderlistmodel-plugin:TARGET",
+        "qtdeclarative5-localstorage-plugin:TARGET",
+        "qtdeclarative5-online-accounts-client0.1:TARGET",
+        "qtdeclarative5-particles-plugin:TARGET",
+        "qtdeclarative5-poppler1.0:TARGET",
+        "qtdeclarative5-qtlocation-plugin:TARGET",
+        "qtdeclarative5-qtorganizer-plugin:TARGET",
+        "qtdeclarative5-qtpositioning-plugin:TARGET",
+        "qtdeclarative5-u1db1.0:TARGET",
+        "qtdeclarative5-ubuntu-content0.1:TARGET",
+        "qtdeclarative5-ubuntu-download-manager0.1:TARGET",
+        "qtdeclarative5-ubuntu-mediascanner0.1:TARGET",
+        "qtdeclarative5-ubuntu-syncmonitor0.1:TARGET",
+        "qtdeclarative5-ubuntu-telephony-phonenumber0.1:TARGET",
+        "qtdeclarative5-ubuntu-ui-toolkit-plugin:TARGET",
+        "qtdeclarative5-usermetrics0.1:TARGET",
+        "qtdeclarative5-xmllistmodel-plugin:TARGET",
+        "qtlocation5-dev:TARGET",
+        "qtmultimedia5-dev:TARGET",
+        "qtscript5-dev:TARGET",
         "qttools5-dev:TARGET",
         "qttools5-dev-tools:TARGET",
+        "ubuntu-html5-theme:TARGET",
+        "ubuntu-ui-toolkit-doc",
         ],
     }