Merge lp:~burger.ga/command-not-found/bug-1073919 into lp:~command-not-found-developers/command-not-found/trunk

Proposed by Gerhard Burger
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 155
Merged at revision: 155
Proposed branch: lp:~burger.ga/command-not-found/bug-1073919
Merge into: lp:~command-not-found-developers/command-not-found/trunk
Diff against target: 16 lines (+3/-3)
1 file modified
CommandNotFound/CommandNotFound.py (+3/-3)
To merge this branch: bzr merge lp:~burger.ga/command-not-found/bug-1073919
Reviewer Review Type Date Requested Status
Zygmunt Krynicki Approve
Review via email: mp+169743@code.launchpad.net

Commit message

fixes bug 1073919 by moving python2 only code (str.decode) to the python2 block

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

if you can, please propose this to

https://github.com/zyga/command-not-found

Otherwise I'll apply it there later today. Thanks

review: Approve
Revision history for this message
Gerhard Burger (burger.ga) wrote :

> +1
>
> if you can, please propose this to
>
> https://github.com/zyga/command-not-found
>
> Otherwise I'll apply it there later today. Thanks

Thanks! Is this a sort of official upstream for command-not-found?
I'll propose this to github as well.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Yeah. I've been trying to move to github for a while now. It's far easier
to contribute to and we can still keep all the bzr imports here (we already
do IIRC)

Thanks
ZK

On Mon, Jun 17, 2013 at 1:24 PM, Gerhard Burger <email address hidden> wrote:

> > +1
> >
> > if you can, please propose this to
> >
> > https://github.com/zyga/command-not-found
> >
> > Otherwise I'll apply it there later today. Thanks
>
> Thanks! Is this a sort of official upstream for command-not-found?
> I'll propose this to github as well.
> --
>
> https://code.launchpad.net/~burger.ga/command-not-found/bug-1073919/+merge/169743
> You are reviewing the proposed merge of lp:~
> burger.ga/command-not-found/bug-1073919 into lp:command-not-found.
>

Revision history for this message
Gerhard Burger (burger.ga) wrote :

Yes, doing it in github is way easier ;)

On Mon, Jun 17, 2013 at 1:31 PM, Zygmunt Krynicki <
<email address hidden>> wrote:

> Yeah. I've been trying to move to github for a while now. It's far easier
> to contribute to and we can still keep all the bzr imports here (we already
> do IIRC)
>
> Thanks
> ZK
>
>
> On Mon, Jun 17, 2013 at 1:24 PM, Gerhard Burger <email address hidden>
> wrote:
>
> > > +1
> > >
> > > if you can, please propose this to
> > >
> > > https://github.com/zyga/command-not-found
> > >
> > > Otherwise I'll apply it there later today. Thanks
> >
> > Thanks! Is this a sort of official upstream for command-not-found?
> > I'll propose this to github as well.
> > --
> >
> >
> https://code.launchpad.net/~burger.ga/command-not-found/bug-1073919/+merge/169743
> > You are reviewing the proposed merge of lp:~
> > burger.ga/command-not-found/bug-1073919 into lp:command-not-found.
> >
>
> --
>
> https://code.launchpad.net/~burger.ga/command-not-found/bug-1073919/+merge/169743
> You are the owner of lp:~burger.ga/command-not-found/bug-1073919.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CommandNotFound/CommandNotFound.py'
2--- CommandNotFound/CommandNotFound.py 2012-06-13 16:09:46 +0000
3+++ CommandNotFound/CommandNotFound.py 2013-06-17 09:13:31 +0000
4@@ -212,9 +212,9 @@
5 answer = input(prompt)
6 else:
7 answer = raw_input(prompt)
8- if sys.stdin.encoding and isinstance(answer, str):
9- # Decode the answer so that we get an unicode value
10- answer = answer.decode(sys.stdin.encoding)
11+ if sys.stdin.encoding and isinstance(answer, str):
12+ # Decode the answer so that we get an unicode value
13+ answer = answer.decode(sys.stdin.encoding)
14 if answer.lower() == _("y"):
15 if posix.geteuid() == 0:
16 command_prefix = ""

Subscribers

People subscribed via source and target branches