Merge ~bullwinkle-team/ubuntu/+source/roctracer:bullwinkle/llvm-21/ubuntu/devel into ubuntu/+source/roctracer:ubuntu/devel

Proposed by Igor Luppi
Status: Merged
Merge reported by: Andreas Hasenack
Merged at revision: ebbc754233a18e09c1d53ff295adca9e478336c6
Proposed branch: ~bullwinkle-team/ubuntu/+source/roctracer:bullwinkle/llvm-21/ubuntu/devel
Merge into: ubuntu/+source/roctracer:ubuntu/devel
Diff against target: 621 lines (+111/-179)
14 files modified
.azuredevops/rocm-ci.yml (+2/-2)
CMakeLists.txt (+2/-2)
LICENSE.md (+8/-7)
debian/changelog (+41/-0)
debian/control (+9/-3)
debian/copyright (+21/-2)
debian/not-installed (+1/-1)
debian/patches/0001-optional-werror.patch (+4/-5)
debian/patches/0002-disable-tests.patch (+5/-5)
debian/patches/0003-optional-roctracer64.patch (+15/-15)
debian/rules (+1/-1)
dev/null (+0/-116)
script/gen_ostream_ops.py (+2/-0)
src/CMakeLists.txt (+0/-20)
Reviewer Review Type Date Requested Status
Frank Heimes (community) Needs Fixing
Ubuntu Sponsors Pending
git-ubuntu import Pending
Review via email: mp+499814@code.launchpad.net

Description of the change

Update to upstream v7.1.0

To post a comment you must log in.
Revision history for this message
Igor Luppi (igorluppi) wrote :

ubuntu@resolute-21:~$ reverse-depends src:roctracer -x
Reverse-Depends
===============
* libmiopen1 [amd64 amd64v3 arm64]
  * libmiopen-dev [amd64 amd64v3 arm64]
  * libmiopen1-tests [amd64 amd64v3 arm64]
* librocblas4 [amd64 amd64v3 arm64]
  * librocblas-dev [amd64 amd64v3 arm64]
  * libhipsolver0 [amd64 amd64v3 arm64]
  * librocsolver0 [amd64 amd64v3 arm64]
  * librocsolver0-tests [amd64 amd64v3 arm64]
  * libmiopen1 [amd64 amd64v3 arm64]
  * libmiopen1-tests [amd64 amd64v3 arm64]
  * librocsolver0-bench [amd64 amd64v3 arm64]
  * libhipblas2 [amd64 amd64v3 arm64]
  * librocblas4-bench [amd64 amd64v3 arm64]
  * librocblas4-tests [amd64 amd64v3 arm64]

Packages without architectures listed are reverse-dependencies in: amd64, amd64v3, arm64, ppc64el
ubuntu@resolute-21:~$ reverse-depends --arch ppc64el src:roctracer -x
No reverse dependencies found

Safe to drop ppc64el

Revision history for this message
Igor Luppi (igorluppi) wrote :
Revision history for this message
Frank Heimes (fheimes) wrote :

Hello Igor, the MR looks pretty good.
It builds fine, lintian is happy if ran on the src and the bins,
licensecheck also didn't found additionally licensed files.

Only request I have is a change of d/changelog,
since it misses a reference to the LP bug.
And while changing it, you could also update the version from 7.1.0-0ubuntu3~ppa1 to just 7.1.0-0ubuntu3 (skipping the ~ppa1 suffix, that would be needed to removed anyway before uploading).

So it should roughly look like:
"
roctracer (7.1.0-0ubuntu3) resolute; urgency=medium

  * Initial release. (LP: #2140348)
  * d/control: remove ppc64el builds

 -- Igor Luppi <email address hidden> Wed, 28 Jan 2026 17:01:32 -0300
"
After this the package seems to be ready to be sponsored.

review: Needs Fixing
Revision history for this message
Frank Heimes (fheimes) wrote :

I noticed that this is not a brand new package upload ([needs-uploading]) rather than a version bump for the current development release.

In this case d/changelog should still have the LP bug reference, for example like this:
roctracer | 6.4.1-1 | resolute/universe | source
(I should have better checked that)

so the changelog should be:
"
roctracer (7.1.0-0ubuntu3) resolute; urgency=medium

  * New upstream release (LP: #2140348)
  * d/control: remove ppc64el builds
 -- Igor Luppi <email address hidden> Wed, 28 Jan 2026 17:01:32 -0300
"

Revision history for this message
Igor Luppi (igorluppi) wrote :

Thanks a lot Frank for the review!

Updated accordingly. Included the bug mention in the New upstream version changelog. Also used the opportunity to fix the UNRELEASED changelogs as well.

Revision history for this message
Igor Luppi (igorluppi) wrote :

Just an update since the MP still as 'needs review':

Roctracer was already merged by git-ubuntu-import https://code.launchpad.net/~git-ubuntu-import/ubuntu/+source/roctracer/+git/roctracer/+ref/ubuntu/devel

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This is in resolute-proposed already, marking as merged.

Revision history for this message
Igor Luppi (igorluppi) wrote :

Thanks Andreas

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.azuredevops/rocm-ci.yml b/.azuredevops/rocm-ci.yml
2index accd3da..87826af 100644
3--- a/.azuredevops/rocm-ci.yml
4+++ b/.azuredevops/rocm-ci.yml
5@@ -13,7 +13,7 @@ trigger:
6 batch: true
7 branches:
8 include:
9- - amd-master
10+ - amd-mainline
11 - amd-staging
12 paths:
13 exclude:
14@@ -26,7 +26,7 @@ pr:
15 autoCancel: true
16 branches:
17 include:
18- - amd-master
19+ - amd-mainline
20 - amd-staging
21 paths:
22 exclude:
23diff --git a/.github/workflows/kws-caller.yml b/.github/workflows/kws-caller.yml
24deleted file mode 100644
25index ffcbff7..0000000
26--- a/.github/workflows/kws-caller.yml
27+++ /dev/null
28@@ -1,15 +0,0 @@
29-name: Rocm Validation Suite KWS
30-on:
31- push:
32- branches: [amd-staging]
33- pull_request:
34- types: [opened, synchronize, reopened]
35- workflow_dispatch:
36-jobs:
37- kws:
38- if: ${{ github.event_name == 'pull_request' }}
39- uses: AMD-ROCm-Internal/rocm_ci_infra/.github/workflows/kws.yml@mainline
40- secrets: inherit
41- with:
42- pr_number: ${{github.event.pull_request.number}}
43- base_branch: ${{github.base_ref}}
44diff --git a/.github/workflows/rocm-ci-caller.yml b/.github/workflows/rocm-ci-caller.yml
45deleted file mode 100644
46index 72533ca..0000000
47--- a/.github/workflows/rocm-ci-caller.yml
48+++ /dev/null
49@@ -1,20 +0,0 @@
50-name: ROCm CI Caller
51-
52-on:
53- pull_request:
54- branches: [release/rocm-rel-6.4]
55- types: [opened, reopened, synchronize]
56- workflow_dispatch:
57-
58-jobs:
59- call-workflow:
60- uses: AMD-ROCm-Internal/rocm_ci_infra/.github/workflows/rocm_ci.yml@mainline
61- secrets: inherit
62- with:
63- input_sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
64- input_pr_num: ${{ github.event_name == 'pull_request' && github.event.pull_request.number || 0 }}
65- input_pr_url: ${{ github.event_name == 'pull_request' && github.event.pull_request.html_url || '' }}
66- input_pr_title: ${{ github.event_name == 'pull_request' && github.event.pull_request.title || '' }}
67- repository_name: ${{ github.repository }}
68- base_ref: ${{ github.event_name == 'pull_request' && github.base_ref || github.ref }}
69- trigger_event_type: ${{ github.event_name }}
70diff --git a/CMakeLists.txt b/CMakeLists.txt
71index 32ab0ce..2b858d2 100644
72--- a/CMakeLists.txt
73+++ b/CMakeLists.txt
74@@ -42,7 +42,7 @@ endif()
75
76 set(CMAKE_CXX_STANDARD 17)
77 set(CMAKE_CXX_STANDARD_REQUIRED ON)
78-add_compile_options(-Wall -Werror)
79+add_compile_options(-Wall -Wno-error=ignored-attributes -Werror)
80 # To set addition RUNPATH in libraries
81 # installed in /opt/rocm-ver/lib/roctracer
82 set(ROCM_APPEND_PRIVLIB_RPATH "$ORIGIN/..")
83@@ -91,7 +91,7 @@ set(CPACK_PACKAGE_VERSION_PATCH ${PROJECT_VERSION_PATCH})
84 set(CPACK_PACKAGE_VERSION "${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSION_MINOR}.${CPACK_PACKAGE_VERSION_PATCH}")
85 set(CPACK_PACKAGE_CONTACT "ROCm Profiler Support <dl.ROCm-Profiler.support@amd.com>")
86 set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "AMD ROCTRACER library")
87-set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE")
88+set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE.md")
89
90 if(DEFINED ENV{ROCM_LIBPATCH_VERSION})
91 set(CPACK_PACKAGE_VERSION "${CPACK_PACKAGE_VERSION}.$ENV{ROCM_LIBPATCH_VERSION}")
92diff --git a/LICENSE b/LICENSE.md
93similarity index 58%
94rename from LICENSE
95rename to LICENSE.md
96index e4103ac..4d43ac8 100644
97--- a/LICENSE
98+++ b/LICENSE.md
99@@ -1,5 +1,6 @@
100-Copyright (c) 2018-2025 Advanced Micro Devices, Inc. All rights reserved.
101-[MITx11 License]
102+MIT License
103+
104+Copyright (C) Advanced Micro Devices, Inc.
105
106 Permission is hereby granted, free of charge, to any person obtaining a copy
107 of this software and associated documentation files (the "Software"), to deal
108@@ -8,13 +9,13 @@ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
109 copies of the Software, and to permit persons to whom the Software is
110 furnished to do so, subject to the following conditions:
111
112-The above copyright notice and this permission notice shall be included in
113-all copies or substantial portions of the Software.
114+The above copyright notice and this permission notice shall be included in all
115+copies or substantial portions of the Software.
116
117 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
118 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
119-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
120+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
121 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
122 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
123-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
124-THE SOFTWARE.
125+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
126+SOFTWARE.
127diff --git a/debian/changelog b/debian/changelog
128index 1dced5a..aac25cd 100644
129--- a/debian/changelog
130+++ b/debian/changelog
131@@ -1,3 +1,44 @@
132+roctracer (7.1.0-0ubuntu3) resolute; urgency=medium
133+
134+ * d/control: remove ppc64el builds
135+
136+ -- Igor Luppi <igor.luppi@canonical.com> Wed, 28 Jan 2026 17:01:32 -0300
137+
138+roctracer (7.1.0-0ubuntu2) UNRELEASED; urgency=medium
139+
140+ * d/{control, rules}: update build dependencies to use upstream llvm-21
141+
142+ -- Talha Can Havadar <talha.can.havadar@canonical.com> Fri, 19 Dec 2025 16:46:38 +0100
143+
144+roctracer (7.1.0-0ubuntu1) UNRELEASED; urgency=medium
145+
146+ [ Zhai Zhaoxuan ]
147+ * chore: New upstream version 7.1.0 (LP: #2140348)
148+ * d/copyright: fix license
149+ * d/control: update build dependencies
150+ * d/rules: include llvm-toolchain-rocm path
151+ * d/not-installed: fix the path of new LICENSE file
152+ * d/p/0001-optional-werror.patch: update for v7.1.0
153+
154+ [ Igor Luppi ]
155+ * d/patches/{0002,0003}: refresh patches indexes
156+
157+ -- Igor Luppi <igor.luppi@canonical.com> Tue, 02 Dec 2025 19:07:25 -0300
158+
159+roctracer (6.4.3-0ubuntu2) resolute; urgency=medium
160+
161+ * d/control: update build-deps to use the 7.1 AMD compiler
162+
163+ -- Andreas Hasenack <andreas.hasenack@canonical.com> Tue, 25 Nov 2025 10:05:07 -0300
164+
165+roctracer (6.4.3-0ubuntu1) questing; urgency=medium
166+
167+ * New upstream version 6.4.3 (no changes needed)
168+ * d/control: update maintainer field for ubuntu archive
169+ * d/control: update build-deps for llvm-toolchain-rocm
170+
171+ -- Igor Luppi <igor.luppi@canonical.com> Wed, 01 Oct 2025 15:53:40 -0300
172+
173 roctracer (6.4.1-1) unstable; urgency=medium
174
175 [ Cordell Bloor ]
176diff --git a/debian/control b/debian/control
177index de7fcdd..9b301e9 100644
178--- a/debian/control
179+++ b/debian/control
180@@ -5,19 +5,25 @@ Priority: optional
181 Standards-Version: 4.7.2
182 Vcs-Git: https://salsa.debian.org/rocm-team/roctracer.git
183 Vcs-Browser: https://salsa.debian.org/rocm-team/roctracer
184-Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
185+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
186+XSBC-Original-Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
187 Uploaders: Cordell Bloor <cgmb@debian.org>,
188 Christian Kastner <ckk@debian.org>,
189 Rules-Requires-Root: no
190 Build-Depends: debhelper-compat (= 13),
191+ clang-format,
192+ clang-tidy,
193 cmake,
194+ hip-utils,
195+ llvm-dev,
196 libhsa-runtime-dev,
197 libamdhip64-dev,
198+ rocm-device-libs-21,
199 python3
200
201 Package: libroctx64-4
202 Section: libs
203-Architecture: amd64 arm64 ppc64el
204+Architecture: amd64 arm64
205 Depends: ${misc:Depends}, ${shlibs:Depends},
206 Description: ROCm library for profiler annotations - library
207 The ROC-TX library provides functions can be used to add information
208@@ -29,7 +35,7 @@ Description: ROCm library for profiler annotations - library
209
210 Package: libroctx-dev
211 Section: libdevel
212-Architecture: amd64 arm64 ppc64el
213+Architecture: amd64 arm64
214 Depends: libroctx64-4 (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends}
215 Description: ROCm library for profiler annotations - headers
216 The ROC-TX library provides functions can be used to add information
217diff --git a/debian/copyright b/debian/copyright
218index a82b5cd..99f4f09 100644
219--- a/debian/copyright
220+++ b/debian/copyright
221@@ -3,14 +3,33 @@ Upstream-Name: roctracer
222 Source: https://github.com/ROCm/roctracer
223
224 Files: *
225-Copyright: 2015-2016, 2018-2024, Advanced Micro Devices, Inc.
226-License: Expat
227+Copyright: Copyright (c) 2018-2025 Advanced Micro Devices, Inc.
228+License: MIT
229
230 Files: debian/*
231 Copyright: 2024-2025, Cordell Bloor <cgmb@debian.org>
232 2025, Christian Kastner <ckk@debian.org>
233 License: Expat
234
235+License: MIT
236+ Permission is hereby granted, free of charge, to any person obtaining a copy
237+ of this software and associated documentation files (the "Software"), to deal
238+ in the Software without restriction, including without limitation the rights
239+ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
240+ copies of the Software, and to permit persons to whom the Software is
241+ furnished to do so, subject to the following conditions:
242+ .
243+ The above copyright notice and this permission notice shall be included in
244+ all copies or substantial portions of the Software.
245+ .
246+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
247+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
248+ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
249+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
250+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
251+ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
252+ THE SOFTWARE.
253+
254 License: Expat
255 Permission is hereby granted, free of charge, to any person obtaining a copy
256 of this software and associated documentation files (the "Software"), to deal
257diff --git a/debian/not-installed b/debian/not-installed
258index d115745..db460d0 100644
259--- a/debian/not-installed
260+++ b/debian/not-installed
261@@ -1 +1 @@
262-usr/share/doc/roctracer*/LICENSE
263+usr/share/doc/roctracer*/LICENSE.md
264diff --git a/debian/patches/0001-optional-werror.patch b/debian/patches/0001-optional-werror.patch
265index 8692101..10abf3b 100644
266--- a/debian/patches/0001-optional-werror.patch
267+++ b/debian/patches/0001-optional-werror.patch
268@@ -9,20 +9,19 @@ Forwarded: https://github.com/ROCm/roctracer/pull/107
269 CMakeLists.txt | 6 +++++-
270 1 file changed, 5 insertions(+), 1 deletion(-)
271
272-diff --git a/CMakeLists.txt b/CMakeLists.txt
273-index 14efcbb..4f22f67 100644
274 --- a/CMakeLists.txt
275 +++ b/CMakeLists.txt
276-@@ -37,7 +37,11 @@ endif()
277+@@ -42,7 +42,12 @@
278
279 set(CMAKE_CXX_STANDARD 17)
280 set(CMAKE_CXX_STANDARD_REQUIRED ON)
281--add_compile_options(-Wall -Werror)
282-+add_compile_options(-Wall)
283+-add_compile_options(-Wall -Wno-error=ignored-attributes -Werror)
284++add_compile_options(-Wall -Wno-error=ignored-attributes)
285 +option(ROCTRACER_WERROR "Treat warnings as errors" ON)
286 +if(ROCTRACER_WERROR)
287 + add_compile_options(-Werror)
288 +endif()
289++
290 # To set addition RUNPATH in libraries
291 # installed in /opt/rocm-ver/lib/roctracer
292 set(ROCM_APPEND_PRIVLIB_RPATH "$ORIGIN/..")
293diff --git a/debian/patches/0002-disable-tests.patch b/debian/patches/0002-disable-tests.patch
294index 6f734d5..51685ca 100644
295--- a/debian/patches/0002-disable-tests.patch
296+++ b/debian/patches/0002-disable-tests.patch
297@@ -9,11 +9,11 @@ Forwarded: not-needed
298 CMakeLists.txt | 2 +-
299 1 file changed, 1 insertion(+), 1 deletion(-)
300
301-diff --git a/CMakeLists.txt b/CMakeLists.txt
302-index 4f22f67..eb783a8 100644
303---- a/CMakeLists.txt
304-+++ b/CMakeLists.txt
305-@@ -60,7 +60,7 @@ endif()
306+Index: roctracer/CMakeLists.txt
307+===================================================================
308+--- roctracer.orig/CMakeLists.txt
309++++ roctracer/CMakeLists.txt
310+@@ -66,7 +66,7 @@
311 add_subdirectory(src)
312
313 ## Build tests
314diff --git a/debian/patches/0003-optional-roctracer64.patch b/debian/patches/0003-optional-roctracer64.patch
315index 61dab83..b66db28 100644
316--- a/debian/patches/0003-optional-roctracer64.patch
317+++ b/debian/patches/0003-optional-roctracer64.patch
318@@ -11,11 +11,11 @@ Forwarded: No
319 src/CMakeLists.txt | 28 +++++++++++++++++-----------
320 2 files changed, 22 insertions(+), 12 deletions(-)
321
322-diff --git a/CMakeLists.txt b/CMakeLists.txt
323-index eb783a8..9cec6de 100644
324---- a/CMakeLists.txt
325-+++ b/CMakeLists.txt
326-@@ -56,6 +56,8 @@ if(NOT DEFINED LIBRARY_TYPE)
327+Index: roctracer/CMakeLists.txt
328+===================================================================
329+--- roctracer.orig/CMakeLists.txt 2025-12-16 13:42:54.709995318 -0300
330++++ roctracer/CMakeLists.txt 2025-12-16 13:42:54.704578626 -0300
331+@@ -62,6 +62,8 @@
332 set(LIBRARY_TYPE SHARED)
333 endif()
334
335@@ -24,7 +24,7 @@ index eb783a8..9cec6de 100644
336 ## Build libraries
337 add_subdirectory(src)
338
339-@@ -65,7 +67,9 @@ if(FALSE)
340+@@ -71,7 +73,9 @@
341 endif()
342
343 ## Build Plugins
344@@ -35,11 +35,11 @@ index eb783a8..9cec6de 100644
345
346 if(${LIBRARY_TYPE} STREQUAL SHARED)
347
348-diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
349-index 8714e11..c0d2d9f 100644
350---- a/src/CMakeLists.txt
351-+++ b/src/CMakeLists.txt
352-@@ -31,6 +31,7 @@ if(DEBUG_TRACE)
353+Index: roctracer/src/CMakeLists.txt
354+===================================================================
355+--- roctracer.orig/src/CMakeLists.txt
356++++ roctracer/src/CMakeLists.txt
357+@@ -31,6 +31,7 @@
358 add_compile_definitions(DEBUG_TRACE_ON=1)
359 endif()
360
361@@ -47,7 +47,7 @@ index 8714e11..c0d2d9f 100644
362 find_package(Python3 COMPONENTS Interpreter REQUIRED)
363
364 execute_process(COMMAND ${Python3_EXECUTABLE} -c "import CppHeaderParser"
365-@@ -91,17 +92,20 @@ add_custom_command(
366+@@ -91,17 +92,20 @@
367 DEPENDS ${PROJECT_SOURCE_DIR}/script/gen_ostream_ops.py "${HIP_RUNTIME_API_H}"
368 COMMENT "Generating hip_ostream_ops.h..."
369 COMMAND_EXPAND_LISTS)
370@@ -78,7 +78,7 @@ index 8714e11..c0d2d9f 100644
371
372 foreach(header ${PUBLIC_HEADERS})
373 get_filename_component(header_subdir ${header} DIRECTORY)
374-@@ -110,6 +114,7 @@ foreach(header ${PUBLIC_HEADERS})
375+@@ -110,6 +114,7 @@
376 COMPONENT dev)
377 endforeach()
378
379@@ -86,7 +86,7 @@ index 8714e11..c0d2d9f 100644
380 set(GENERATED_HEADERS
381 hip_ostream_ops.h
382 hsa_prof_str.h
383-@@ -179,6 +184,7 @@ install(TARGETS roctracer LIBRARY
384+@@ -179,6 +184,7 @@
385 install(TARGETS roctracer LIBRARY
386 DESTINATION ${CMAKE_INSTALL_LIBDIR}
387 COMPONENT asan)
388@@ -94,7 +94,7 @@ index 8714e11..c0d2d9f 100644
389
390 ## Build the ROCTX library
391 file(GLOB ROCTX_SOURCES "roctx/*.cpp")
392-@@ -211,7 +217,7 @@ install(TARGETS roctx LIBRARY
393+@@ -211,7 +217,7 @@
394 COMPONENT asan)
395
396 ## Build the tracer_tool library
397diff --git a/debian/rules b/debian/rules
398index 453e79c..8968828 100755
399--- a/debian/rules
400+++ b/debian/rules
401@@ -9,7 +9,7 @@ export VERBOSE=1
402 CMAKE_FLAGS = \
403 -DFILE_REORG_BACKWARD_COMPATIBILITY=OFF \
404 -DBUILD_ROCTRACER64=OFF \
405- -DROCTRACER_WERROR=OFF
406+ -DROCTRACER_WERROR=OFF
407
408 %:
409 dh $@
410diff --git a/header_template.hpp.in b/header_template.hpp.in
411deleted file mode 100644
412index 627fefd..0000000
413--- a/header_template.hpp.in
414+++ /dev/null
415@@ -1,43 +0,0 @@
416-/*
417- Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
418-
419- Permission is hereby granted, free of charge, to any person obtaining a copy
420- of this software and associated documentation files (the "Software"), to deal
421- in the Software without restriction, including without limitation the rights
422- to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
423- copies of the Software, and to permit persons to whom the Software is
424- furnished to do so, subject to the following conditions:
425-
426- The above copyright notice and this permission notice shall be included in
427- all copies or substantial portions of the Software.
428-
429- THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
430- IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
431- FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
432- AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
433- LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
434- OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
435- THE SOFTWARE.
436- */
437-
438-#ifndef @include_guard@
439-#define @include_guard@
440-
441-#ifndef ROCM_HEADER_WRAPPER_WERROR
442-#define ROCM_HEADER_WRAPPER_WERROR @deprecated_error@
443-#endif
444-#if ROCM_HEADER_WRAPPER_WERROR /* ROCM_HEADER_WRAPPER_WERROR 1 */
445-#error "This file is deprecated. Use file from include path /opt/rocm-ver/include/ and prefix with roctracer"
446-#else /* ROCM_HEADER_WRAPPER_WERROR 0 */
447-#if defined(__GNUC__)
448-#warning "This file is deprecated. Use file from include path /opt/rocm-ver/include/ and prefix with roctracer"
449-#else
450-#pragma message("This file is deprecated. Use file from include path /opt/rocm-ver/include/ and prefix with roctracer")
451-#endif
452-#endif /* ROCM_HEADER_WRAPPER_WERROR */
453-
454-@include_statements@
455-
456-#endif
457-
458-@original_contents@
459diff --git a/roctracer-backward-compat.cmake b/roctracer-backward-compat.cmake
460deleted file mode 100644
461index 36b49ea..0000000
462--- a/roctracer-backward-compat.cmake
463+++ /dev/null
464@@ -1,116 +0,0 @@
465-# Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
466-# Permission is hereby granted, free of charge, to any person obtaining a copy
467-# of this software and associated documentation files (the "Software"), to deal
468-# in the Software without restriction, including without limitation the rights
469-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
470-# copies of the Software, and to permit persons to whom the Software is
471-# furnished to do so, subject to the following conditions:
472-#
473-# The above copyright notice and this permission notice shall be included in
474-# all copies or substantial portions of the Software.
475-#
476-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
477-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
478-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
479-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
480-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
481-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
482-# THE SOFTWARE.
483-
484-cmake_minimum_required(VERSION 3.16.8)
485-
486-set(ROCT_BUILD_DIR ${CMAKE_CURRENT_BINARY_DIR})
487-set(ROCT_WRAPPER_DIR ${ROCT_BUILD_DIR}/wrapper_dir)
488-set(ROCT_WRAPPER_INC_DIR ${ROCT_WRAPPER_DIR}/include)
489-set(ROCT_WRAPPER_LIB_DIR ${ROCT_WRAPPER_DIR}/lib)
490-#set(ROCT_WRAPPER_TOOL_DIR ${ROCT_WRAPPER_DIR}/tool)
491-
492-#Function to set actual file contents in wrapper files
493-#Some components grep for the contents in the file
494-function(set_file_contents input_file)
495- set(hashzero_check "#if 0 //Area for original file dump\n
496-/* The following is a copy of the original file for the benefit of build systems which grep for values
497- * in this file rather than preprocess it. This is just for backward compatibility */")
498-
499- file(READ ${input_file} file_contents)
500- set(original_contents "${hashzero_check}\n
501-${file_contents}
502-#endif")
503- get_filename_component(file_name ${input_file} NAME)
504- configure_file(${PROJECT_SOURCE_DIR}/header_template.hpp.in ${ROCT_WRAPPER_INC_DIR}/${file_name})
505-endfunction()
506-
507-#use header template file and generate wrapper header files
508-function(generate_wrapper_header)
509- file(MAKE_DIRECTORY ${ROCT_WRAPPER_INC_DIR}/ext)
510- #Get the header files from PUBLIC_HEADERS variable
511- foreach(header_file ${PUBLIC_HEADERS})
512- #set include guard
513- get_filename_component(INC_GAURD_NAME ${header_file} NAME_WE)
514- string(TOUPPER ${INC_GAURD_NAME} INC_GAURD_NAME)
515- set(include_guard "ROCTRACER_WRAPPER_INCLUDE_${INC_GAURD_NAME}_H")
516- #set include statements
517- get_filename_component(file_name ${header_file} NAME)
518- get_filename_component ( header_subdir ${header_file} DIRECTORY )
519- if(header_subdir)
520- set(include_statements "#include \"../../../${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME}/${header_subdir}/${file_name}\"\n")
521- configure_file(${PROJECT_SOURCE_DIR}/header_template.hpp.in ${ROCT_WRAPPER_INC_DIR}/${header_subdir}/${file_name})
522- else()
523- set(include_statements "#include \"../../${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME}/${file_name}\"\n")
524- if(${file_name} STREQUAL "roctracer.h")
525- set_file_contents(${PROJECT_SOURCE_DIR}/inc/${file_name})
526- else()
527- configure_file(${PROJECT_SOURCE_DIR}/header_template.hpp.in ${ROCT_WRAPPER_INC_DIR}/${file_name})
528- endif()
529- endif()
530- endforeach()
531-
532- foreach(header_file ${GENERATED_HEADERS})
533- #set include guard
534- get_filename_component(INC_GAURD_NAME ${header_file} NAME_WE)
535- string(TOUPPER ${INC_GAURD_NAME} INC_GAURD_NAME)
536- set(include_guard "ROCTRACER_WRAPPER_INCLUDE_${INC_GAURD_NAME}_H")
537- #set include statements
538- get_filename_component(file_name ${header_file} NAME)
539- set(include_statements "#include \"../../${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME}/${file_name}\"\n")
540- configure_file(${PROJECT_SOURCE_DIR}/header_template.hpp.in ${ROCT_WRAPPER_INC_DIR}/${file_name})
541-
542- endforeach()
543-
544-endfunction()
545-
546-#function to create symlink to libraries
547-function(create_library_symlink)
548- file(MAKE_DIRECTORY ${ROCT_WRAPPER_LIB_DIR})
549- set(LIB_ROCT "libroctracer64.so")
550- set(MAJ_VERSION "${PROJECT_VERSION_MAJOR}")
551- set(SO_VERSION "${PROJECT_VERSION}")
552- set(library_files "${LIB_ROCT}") #"${LIB_ROCT}.${MAJ_VERSION}" "${LIB_ROCT}.${SO_VERSION}")
553-
554- set(LIB_ROCTX64 "libroctx64.so")
555- set(library_files "${library_files}" "${LIB_ROCTX64}") # "${LIB_ROCTX64}.${MAJ_VERSION}" "${LIB_ROCTX64}.${SO_VERSION}" )
556-
557- foreach(file_name ${library_files})
558- add_custom_target(link_${file_name} ALL
559- WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
560- COMMAND ${CMAKE_COMMAND} -E create_symlink
561- ../../${CMAKE_INSTALL_LIBDIR}/${file_name} ${ROCT_WRAPPER_LIB_DIR}/${file_name})
562- endforeach()
563- #set softlink for roctracer/tool/libtracer_tool.so
564- #The libray name is changed to libroctracer_tool.so with file reorg changes
565- #file(MAKE_DIRECTORY ${ROCT_WRAPPER_TOOL_DIR})
566- #set(LIB_TRACERTOOL "libtracer_tool.so")
567- #set(LIB_ROCTRACERTOOL "libroctracer_tool.so")
568- #add_custom_target(link_${LIB_TRACERTOOL} ALL
569- # WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
570- # COMMAND ${CMAKE_COMMAND} -E create_symlink
571- # ../../lib/${PROJECT_NAME}/${LIB_ROCTRACERTOOL} ${ROCT_WRAPPER_TOOL_DIR}/${LIB_TRACERTOOL})
572-endfunction()
573-
574-#Use template header file and generater wrapper header files
575-generate_wrapper_header()
576-install(DIRECTORY ${ROCT_WRAPPER_INC_DIR} DESTINATION ${PROJECT_NAME} COMPONENT dev)
577-create_library_symlink()
578-install(DIRECTORY ${ROCT_WRAPPER_LIB_DIR} DESTINATION ${PROJECT_NAME} COMPONENT dev)
579-#install soft link to tool
580-#install(DIRECTORY ${ROCT_WRAPPER_TOOL_DIR} DESTINATION ${PROJECT_NAME})
581diff --git a/script/gen_ostream_ops.py b/script/gen_ostream_ops.py
582index 9b45cb4..dcc9914 100755
583--- a/script/gen_ostream_ops.py
584+++ b/script/gen_ostream_ops.py
585@@ -241,6 +241,8 @@ def gen_cppheader(infilepath, outfilepath, rank):
586 continue
587 if c == 'max_align_t' or c == '__fsid_t': # Skipping as it is defined in multiple domains
588 continue
589+ if c.startswith("_") or c.startswith("pthread_") or c.startswith("__pthread_"):
590+ continue
591 if len(cppHeader.classes[c]["properties"]["public"]) != 0:
592 output_filename_h.write("inline static std::ostream& operator<<(std::ostream& out, const " + c + "& v)\n")
593 output_filename_h.write("{\n")
594diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
595index 0c15c4d..eeb90c2 100644
596--- a/src/CMakeLists.txt
597+++ b/src/CMakeLists.txt
598@@ -243,23 +243,3 @@ install(TARGETS hip_stats LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}/${PROJECT_
599 install(TARGETS hip_stats LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}/${PROJECT_NAME} COMPONENT asan)
600
601 endif()
602-
603-option(FILE_REORG_BACKWARD_COMPATIBILITY "Enable File Reorg with backward compatibility" OFF)
604-
605-if(FILE_REORG_BACKWARD_COMPATIBILITY)
606-## To enable/disable #error in wrapper header files
607- if(NOT DEFINED ROCM_HEADER_WRAPPER_WERROR)
608- if(DEFINED ENV{ROCM_HEADER_WRAPPER_WERROR})
609- set(ROCM_HEADER_WRAPPER_WERROR "$ENV{ROCM_HEADER_WRAPPER_WERROR}"
610- CACHE STRING "Header wrapper warnings as errors.")
611- else()
612- set(ROCM_HEADER_WRAPPER_WERROR "OFF" CACHE STRING "Header wrapper warnings as errors.")
613- endif()
614- endif()
615- if(ROCM_HEADER_WRAPPER_WERROR)
616- set(deprecated_error 1)
617- else()
618- set(deprecated_error 0)
619- endif()
620- include(${PROJECT_SOURCE_DIR}/roctracer-backward-compat.cmake)
621-endif()

Subscribers

People subscribed via source and target branches