Merge ~bullwinkle-team/ubuntu/+source/rocblas:bullwinkle/llvm-21/ubuntu/devel into ubuntu/+source/rocblas:ubuntu/devel

Proposed by Igor Luppi
Status: Approved
Approved by: Andreas Hasenack
Approved revision: 20b81e8a018008570abc90b39e0038a07bb952a9
Proposed branch: ~bullwinkle-team/ubuntu/+source/rocblas:bullwinkle/llvm-21/ubuntu/devel
Merge into: ubuntu/+source/rocblas:ubuntu/devel
Diff against target: 0 lines
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Frank Heimes (community) Approve
Ubuntu Sponsors Pending
Review via email: mp+499829@code.launchpad.net

Description of the change

Update to upstream v7.1.0

To post a comment you must log in.
Revision history for this message
Igor Luppi (igorluppi) wrote :

~$ reverse-depends --arch ppc64el src:rocblas -x
Reverse-Depends
===============
* libggml-hip (for librocblas0)

Although ggml has dependency in rocblas, it is only amd64 and arm64:
               librocblas-dev [amd64 arm64] <!pkg.ggml.nohip>,

Its safe to drop ppc64el. Actually, it was already dropped in debian: https://git.launchpad.net/ubuntu/+source/rocblas/commit/?id=e7a6f73b6ff74b1703928c78b483e8bb64bc5d2c

I have done a rebase to include this commit.

Revision history for this message
Igor Luppi (igorluppi) wrote :

Build in ppa: https://launchpad.net/~igorluppi/+archive/ubuntu/rocblas-lp2140431

(-proposed and all archs enabled)

Revision history for this message
Igor Luppi (igorluppi) wrote :

The src:roctracer package has been accepted into the proposed archive, re-building https://launchpad.net/~igorluppi/+archive/ubuntu/rocblas-lp2140431/+packages

Revision history for this message
Igor Luppi (igorluppi) wrote :

rebased with ubuntu/devel branch

Revision history for this message
Andreas Hasenack (ahasenack) wrote (last edit ):

+ * d/changelog: update for b-d changes
+ * d/changelog: update changelog to add notes for libamdhip64-dev and version changes in build-depends

This looks odd in the d/changelog file itself :) But ok if it helps you this time. I think I have only seen such self references when the changelog was broken somewhere prior.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

--- /dev/null
+++ b/debian/ci/bullwinkle.sources
@@ -0,0 +1,34 @@
+Types: deb
+URIs: https://ppa.launchpadcontent.net/bullwinkle-team/rocm-devel/ubuntu/
+Suites: resolute
+Components: main
+Signed-By:
+ -----BEGIN PGP PUBLIC KEY BLOCK-----
+ .
+ mQINBGijNqIBEADp0QJi+IFq6RcZp2MZUGZocXBePMQvcwTOVQhrY8wJmbahllXb
...

Do we really need this? Same case as with another package recently, but there it was removed.

review: Needs Information
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

There is some annoying extra whitespace at the end of some debian/*.links files:
--- /dev/null
+++ b/debian/librocblas5-bench.links
@@ -0,0 +1 @@
+usr/share/bug/librocblas5 usr/share/bug/librocblas5-bench

--- /dev/null
+++ b/debian/librocblas5-tests.links
@@ -0,0 +1 @@
+usr/share/bug/librocblas5 usr/share/bug/librocblas5-tests

Revision history for this message
Igor Luppi (igorluppi) wrote :

Thanks Andreas, I ll take a look for the required changes.

The other pkg rocfft, debian/ci commit was just dropped? I can just drop d/ci: add customizations for salsa ci for ubuntu build. as well

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> debian/ci commit was just dropped

It doesn't hurt the ubuntu build. Does it help your team to have it in place? Is any of this being run on debian ci? I presume the ppa will become obsolete soon, as we are uploading all of these to the archive.

Revision history for this message
Talha Can Havadar (tchavadar) wrote :

We can still keep ppa around for some cases but it is totally fine to drop Debian/ci changes we are not relying on that

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

If you want to keep debian/ci, then please document it in d/changelog, including the changes to debian/salsa-ci.yml.

Revision history for this message
Frank Heimes (fheimes) wrote :

I had a look at Igor's latest ubuntu3.
The MR looks okay, except that no LP bug is referenced in d/changelog - I've added it.
I left ubuntu2 and ubuntu1 version in the changelog to now loose any meta data (but as unreleased).
lintian is okay on the src and the bin files.
The package build fine in my PPA (roctracer as pre-req.).
It looks to be ready to be sponsored.

review: Approve
Revision history for this message
Igor Luppi (igorluppi) wrote :

Thanks @Andreas and @Talha for the feedback.

@Andreas all the following changes have been made accordingly:

- Updated changelog: all repeated changelog changes have been squashed and placed after the changes. Also, self references have been deleted (no longer required).
- Removed annoying extra whitespaces from *.links files.
- Dropped d/ci/bullwinkle.sources changes (not needed)

Could take another look please?

Revision history for this message
Igor Luppi (igorluppi) wrote :

Just a warning: launchpad is not refreshing ~bullwinkle-team/ubuntu/+source/rocblas:bullwinkle/llvm-21/ubuntu/devel

Although it is up-to-date using git in terminal ($ Everything up-to-date) it is not showing up in the webpage here (https://code.launchpad.net/~bullwinkle-team/ubuntu/+source/rocblas/+git/rocblas/+ref/bullwinkle/llvm-21/ubuntu/devel). Do not upload until LP shows the updates please.

Revision history for this message
Igor Luppi (igorluppi) wrote :

Refreshed in LP webpage. Please take a look.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

There are only amd64 symbols. As this was already the case, and not introduced by this branch, please file a bug so that the symbols coverage can be completed later.

+1

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Sponsored:

Uploading rocblas_7.1.0-0ubuntu3.dsc
Uploading rocblas_7.1.0.orig-tensile.tar.gz
Uploading rocblas_7.1.0.orig.tar.gz
Uploading rocblas_7.1.0-0ubuntu3.debian.tar.xz
Uploading rocblas_7.1.0-0ubuntu3_source.buildinfo
Uploading rocblas_7.1.0-0ubuntu3_source.changes

Revision history for this message
Igor Luppi (igorluppi) wrote :

Thanks for the suggestion. It was created here https://bugs.launchpad.net/ubuntu/+source/rocblas/+bug/2141338

Unmerged commits

e30dade... by Igor Luppi

7.1.0-0ubuntu3 (patches unapplied)

Imported using git-ubuntu import.

20b81e8... by Igor Luppi

d/changelog: new resolute entry

e01be62... by Igor Luppi

d/rules: filter gfx11-generic from rocm-target-arch

61deb66... by Talha Can Havadar

d/changelog: update b-d and adapt to use llvm-21 upstream

6395358... by Talha Can Havadar

d/control: make sure to use rocm 7.1.0 in build depends

ab989f5... by Talha Can Havadar

d/control: add libamdhip64-dev as build dependency

bef028f... by Talha Can Havadar

d/librocblas5.symbols.amd64: remove debian revision from symbols

f0a1ae4... by Talha Can Havadar

d/p/update-toolchain-defaults-for-upstream-llvm.patch

defaults were forcing build to use binaries only provided by amd fork
without proper way to overwrite them.

36f4299... by Talha Can Havadar

d/{control,rules}: update b-d to use upstream llvm-21

fd7803e... by Talha Can Havadar

d/changelog: mark 6.4.3 ppa questing release as UNRELEASED

Preview Diff

Empty

Subscribers

People subscribed via source and target branches