Revert "LP#1945385: use eg-admin-page for circ limit sets admin UI"
This reverts commit 5380bfb11a3a38bac521ce8ef92216c13d46f3b9.
The reverted code raises the following error in 3.7:
ERROR in
src/app/staff/admin/local/circ_limit_set/circ_limit_set.component.html:4:32
- error NG8002: Can't bind to 'templateFields' since it isn't a known
property of 'eg-admin-page'.
Signed-off-by: Jason Stephenson <email address hidden>
Revert "LP#1851884: eg-fm-record-editor: avoid fetching all rows from linked table"
This reverts commit f2824b8457fa1e941053cdc7fa715ab21e6f58c9.
It causes the following error when building Angular:
ERROR in src/app/share/fm-editor/fm-editor.component.ts:517:30 - error TS2339: Property 'linkedSearchConditions' does not exist on type 'FmFieldOptions'.
517 if (fieldOptions.linkedSearchConditions) { ~~~~~~~~~~~~~~~~~~~~~~
src/app/share/fm-editor/fm-editor.component.ts:518:51 - error TS2339: Property 'linkedSearchConditions' does not exist on type 'FmFieldOptions'.
There does not appear to be any way to resolve this as the patch also
relies on other changes in rel_3_8 and rel_3_9 that are not present in
rel_3_7. For these reasons, I am reverting the patch from rel_3_7.
Signed-off-by: Jason Stephenson <email address hidden>
LP 1975861: Fix the Patch for Lp 1909681 on rel_3_7
The change to the Hopeless Holds Interface for opening title links in
a new tab was missed in the 3.7 backport of the branch from bug
1909681. This commit adds it back.
NOTE: This branch is for rel_3_7 and ONLY rel_3_7. Other Evergreen
branches do not need it.
Signed-off-by: Jason Stephenson <email address hidden>
f2824b8...
by
Galen Charlton <email address hidden>
LP#1851884: eg-fm-record-editor: avoid fetching all rows from linked table
This patch ensures that Angular FM record editor dialogs do
not attempt to fetch all rows from target table when constructing
a combobox for a linked field.
In particular, it makes the following changes:
* If a custom template for a field is supplied, use that by
default rather than _also_ creating a data source for
a combobox.
* Rather than creating its own data source for a linked field,
the FM record editor now uses the IDL mode of eg-combobox. By doing
this, we use eg-combobox's default data source, which limits
record retrievals to 100 rows max. Also, empty-click is now
enabled by default.
* When attempting to identify a selector for an IDL class, if
the class doesn't define a selector and doesn't have a field named
'name', but its primary key is a text field, use the primary
key as the selector.
To test
-------
[1] Create a few thousand empty bib record buckets in your test database.
[2] Edit a carousel under Local Administration; note that it can
take some time for the dialog to load.
[3] Apply the patch and repeat step 2. This time, the carousel edit modal
should open instantly.
[4] Test various Angular record editor modals to confirm that they behave
as expected. For example:
* The allocate to fund dialog in Fund Administration, in particular
to verify that only active funds show up.
* The assign user to course modal, to verify that searching is done
by course number, not name.
* Filter Dialog Set editor under /eg2/en-US/staff/admin/local/config/filter_dialog_filter_set
to verify that the drop down for the creator doesn't fetch
all patrons. (Note that this is an artificial example).
LP#1945385: use eg-admin-page for circ limit sets admin UI
Signed-off-by: Jeff Davis <email address hidden>
Signed-off-by: Jennifer Pringle <email address hidden>
Signed-off-by: Jason Stephenson <email address hidden>
