LP#1635386: Restore to xul colors and remove colors from class names
This commit restores the xul display where overdue items were highlighted
in red and long overdue items were highlighted in orange. Also removes
the colors from the class names since people may decide to use totally different
colors or style the rows in different ways.
LP#1635386 Clarify and simplify row highlighting code
The existing code had a few functional problems for me. In the process
of fixing them, I decided it best to also apply a number of small
refactorings. Here is a list of changes in rough order of significance:
-Made the new CSS classes test and apply once per row rather than once
per cell
-Fixed the test case for overdues: we now just look for no checkin-time
+ no lost/long-overdue stop-fines (matches XUL test)
-Made the color and icon tests totally consistent, and also simplified
where possible
-Made the widened configuration header style (to accommodate status
column) functional again (it was using old 'statusicon' class)
-Made row highlight colors '!important' to avoid bad interactions with
alternating row color styles
-Changed status-cell (and statusCell) to status-column (and
statusColumn) for a little extra clarity
-Changed nested function name from 'rowClass()' to 'apply()' for greater
code distinction (i.e. avoid 'rowClass.rowClass()' calls, and instead
have 'rowClass.apply()')
-Removed some unused variable assignments from grid.js
-Cleaned up a few field attributes for necessity and consistency
Signed-off-by: Dan Wells <email address hidden>
Signed-off-by: Kathy Lussier <email address hidden>
Signed-off-by: Dawn Dale <email address hidden>
LP#1635386: Improve contrast for colors used in Bills interface
The contrast between cell contents and background colors did not
meet WCAG standards. This commit provides adequate contrast to
meet AA level of WCAG standards. The red and dark red background
colors are similar to what we saw in the XUL client. The orange
for long overdue is much lighter.
Signed-off-by: Kathy Lussier <email address hidden>
Signed-off-by: Dan Wells <email address hidden>
Signed-off-by: Dawn Dale <email address hidden>
