Signed-off-by: Andrea Buntz Neiman <email address hidden>
Signed-off-by: Jane Sandberg <email address hidden>
697e241...
by
James Fournie <email address hidden>
LP1751800 - fix fields fields reversing
The pop() here will remove the last item in the array, only to add it
later with a push() a few lines later. Instead use a shift() to
preserve the order.
Signed-off-by: James Fournie <email address hidden>
Signed-off-by: Remington Steed <email address hidden>
Signed-off-by: Dan Wells <email address hidden>
LP#1785061: move the filter value munging to the template service
This allows the reporter app to stay a bit more focused on
display concerns.
Here's a test plan for the patch series
---------------------------------------
[1] Create a reporter template that has a filter field
and a filter operator of "In list", "Not in list", "Between",
or "Not between" and hard-code a value for that filter
in the template, separating values with a comma.
[2] Try to create a report from that template; note that it
fails with an error.
[3] Apply the patch and repeat steps 1 and 2. This time, the
report should succeed.
Note that this fix applies only to hardcoding filter values in the
template; it doesn't change any behavior when attempting to set
a filter value for any of the four operators above at the point of
creating a report.
LP#1785061: Split filter value on comma for "in list" and the like
This commit borrows directly from the XUL reporter code (see
function __default_value_event_handler () in
Open-ILS/web/reports/xul/template-config.js). Basically, when the filter
value is saved, certain cases need special treatment, such as splitting
an "in list" value on commas. This commit includes a helper function
which does the special treatment and saves the filter value. This helper
is called both when the value itself is changed, and when the operator
is changed.
LP#1722827: trim spaces from 856$9 when parsing locating URIs
This patch ensures that any leading and trailing spaces
and non-breaking-spaces in the 856$9 are ignored when
extracting the org unit shortname. As a consequence,
extraneous leading/trailing whitespace in the $9 will not
prevent the located URI from being displayed in the appropriate
places.
LP#1511765 Fix error when checking in with zero-balance lost OU setting enabled
Fixes an error generated when checking in Lost/Long Overdue/Lost and Paid
items with no associated circ when the org unit setting
circ.checkin.lost_zero_balance.do_not_change is set to TRUE
Items can attain this state from migration, or when the associated circ
has been aged.