4e266ea...
by
Lebbeous Fogle-Weekley <email address hidden>
Serials: change more carp() to croak() to avoid infinite loops
This addresses a problem very similar to that in LP #1075167, where
certain loops never end because problems with the data elicited calls to
carp(), which fills up log, but never gives our loops notice to end.
Visible symptoms include 1) a greate volume of log spew and 2) an
open-ils.serial drone that ties up a CPU.
The fault lies maybe in our loops rather than in the MFHD
package, but this fixes the problem fastest, and should not have
undesirable side-effects.
LP#1067361: vandelay: batch queue deletion no longer works
Because window.location.reload can trigger before the deletions
have occurred. Simple fix (band aid?) is to make the delete
calls in sync.
Signed-off-by: Mark Cooper <email address hidden>
Signed-off-by: Kathy Lussier <email address hidden>
Signed-off-by: Ben Shum <email address hidden>
64658bb...
by
Jason Etheridge <email address hidden>
LP1053526 - Don't inadvertently modify the in-memory org tree when printing
To see an example of this causing a problem, load Holdings Maintenance for
an arbitrary bib record with items. Make sure the Hide Empty Libs checkbox
is checked. Hit the Print button at the bottom of the UI (it's okay to then
Cancel the print). Then hit Refresh. It should result in an org.children()
is null error.
Signed-off-by: Jason Etheridge <email address hidden>
Signed-off-by: Ben Shum <email address hidden>
Copy_offset and copy_limit shouldn't persist in URL
Added copy_offset and copy_limit to stop_parms definition so that they
don't persist in URL when returning to search results or launching
subject/series searches.
Signed-off-by: Kathy Lussier <email address hidden>
Signed-off-by: Pasi Kallinen <email address hidden>
Signed-off-by: Ben Shum <email address hidden>
4f0b0ec...
by
Lebbeous Fogle-Weekley <email address hidden>
Serials: Caption/pattern wizard use enum fields for chronology when no enum
MFHD spec says that when there are no ‡a - ‡f enumeration captions, any
chronology captions should move back from their usual ‡i - ‡m places
back into enumeration space.
The predictions engine we already have deals with this better than with
the wrong patterns we were creating before, e.g.:
If a site had not set an 'org.patron_opt_default' OU setting, then it
seemed that a DEFAULT value was getting dumped into the "create opt-in"
INSERT statement for the org_unit argument, and that (as there is a
non-NULL constraint on the column and no default value for the column)
resulted in the patron not getting opted in.
One way for sites to deal with this is to set an opt-in boundary at the
consortial level, along the lines of:
INSERT INTO actor.org_unit_setting (org_unit, name, value)
VALUES (1, 'org.patron_opt_default', 2);
Alternatively, in the absense of any such setting, opt-in should
continue to work as it had before the new feature was added; this change
keeps the old behaviour active in that case.
Signed-off-by: Dan Scott <email address hidden>
Signed-off-by: James Fournie <email address hidden>
Signed-off-by: Ben Shum <email address hidden>
