Code review comment for ~bryce/ubuntu/+source/php-parser:merge-v4.10.4-1-hirsute

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

* Changelog:
  - [X] old content and logical tag match as expected
    The tags were not uploaded to the repository
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
  - [√] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [√] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [√] no new patches added
  - [-] patches match what was proposed upstream
  - [-] patches correctly included in debian/patches/series
  - [-] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [√] verified PPA package installs/uninstalls
  - [√] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

LGTM, and I verified that the dep8 tests are indeed passing:

autopkgtest [09:23:07]: @@@@@@@@@@@@@@@@@@@@ summary
command1 PASS

There is a lintian error that should be fixed IMO:

E: php-parser source: quilt-series-without-trailing-newline

Just add a trailing newline at the end of d/series :-).

Feel free to go ahead and push/upload with this fixed. Thanks!

review: Needs Fixing

« Back to merge proposal