Merge ~bryce/ubuntu/+source/php-msgpack:php-transition-php7x4-c-focal into ~bryce/ubuntu/+source/php-msgpack:master

Proposed by Bryce Harrington
Status: Merged
Approved by: Bryce Harrington
Approved revision: 33b43b3961db1c4b007f6581755300a313fd27c2
Merge reported by: Bryce Harrington
Merged at revision: 33b43b3961db1c4b007f6581755300a313fd27c2
Proposed branch: ~bryce/ubuntu/+source/php-msgpack:php-transition-php7x4-c-focal
Merge into: ~bryce/ubuntu/+source/php-msgpack:master
Diff against target: 0 lines
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Bryce Harrington Pending
Review via email: mp+379773@code.launchpad.net

Description of the change

Merge from upstream's tarball, using gbp to import it into debian's packaging.

Without this, php-msgpack won't build against php7.4. Several other php packages depend on this.

This is included in the PHP ppa:
https://launchpad.net/~bryce/+archive/ubuntu/php7.4-transition

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

You dropped the last patch that was left, and d/rules is one line (pecl build) - this looks good right from the start.
obviously having a beta isn't perfect but if it is the only thing that gets 7.4 going why not.

Changelog:
- [√] changelog entry correct version and targeted codename
- [√] changelog entries correct
- [√] update-maintainer has been run

Actual changes:
- [√] no major upstream changes to consider
- [√] no further upstream version to consider
- [na] debian changes look safe

Old Delta:
- [√] dropped changes are ok to be dropped
- [√] nothing else to drop
- [√] changes forwarded upstream/debian (if appropriate)

Note: the packaging with the versioned subdir is odd (to me) but seems to work.
Due to that the upstream update is a full --all ++all.

New Delta:
- [√] no new patches added

Build/Test:
- [√] build is ok
- [√] build time self-test is ok
- [√] no autopkgtest present to test
- [√] sanity checks are fine

The dep to phpapi-20190902 also confirms it really really built for the new api.

Note: there are quite a lot of compile-time warnings thrown, but I checked the current 2.0.3-1 and it is the same there - so maybe we accept that.
You only tested amd64 builds, if php packages generally have no issues cross arch that is fine, otherwise please enable other architectures in your ppa.

+1

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the review, uploaded to -proposed.

$ dput ubuntu php-msgpack_2.1.0beta1-0ubuntu1_source.changes
Checking signature on .changes
gpg: /home/bryce/ubuntu/Php7.4/php-msgpack/php-msgpack_2.1.0beta1-0ubuntu1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: /home/bryce/ubuntu/Php7.4/php-msgpack/php-msgpack_2.1.0beta1-0ubuntu1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading php-msgpack_2.1.0beta1-0ubuntu1.dsc: done.
  Uploading php-msgpack_2.1.0beta1.orig.tar.gz: done.
  Uploading php-msgpack_2.1.0beta1-0ubuntu1.debian.tar.xz: cd done.
  Uploading php-msgpack_2.1.0beta1-0ubuntu1_source.buildinfo: done.
  Uploading php-msgpack_2.1.0beta1-0ubuntu1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Bryce Harrington (bryce) wrote :

And yeah, I notice a lot of warnings in php packages generally, I think they're just not super thoroughly maintained...

I've enabled other arch's in the ppa, thanks for the reminder. In fact, after uploading this I found that armhf and arm64 are FTBFS due to a test case failure.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Still FTBFS:
 php-msgpack | 2.0.3+0.5.7-3 | focal-proposed/universe | arm64, armhf
 php-msgpack | 2.1.0beta1-0ubuntu1 | focal-proposed/universe | source, amd64, ppc64el, s390x

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI I landed the follow on fix for the FTBFS

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: