Merge ~bryce/ubuntu/+source/php-defaults:merge-v80--exp1-impish into ubuntu/+source/php-defaults:debian/experimental
Status: | Merged |
---|---|
Approved by: | Bryce Harrington |
Approved revision: | 1fcac8774127045e29790322d64d78f3b1887ff9 |
Merge reported by: | Bryce Harrington |
Merged at revision: | 1fcac8774127045e29790322d64d78f3b1887ff9 |
Proposed branch: | ~bryce/ubuntu/+source/php-defaults:merge-v80--exp1-impish |
Merge into: | ubuntu/+source/php-defaults:debian/experimental |
Diff against target: |
59 lines (+20/-2) 3 files modified
debian/changelog (+16/-0) debian/control (+2/-1) debian/control.in (+2/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
git-ubuntu developers | Pending | ||
Review via email: mp+402607@code.launchpad.net |
Description of the change
This is a merge of php-defaults from Debian experimental. They took the ubuntu delta, so this merge can be a sync from that standpoint, but this includes additional changes from Debian worth review.
stirling:
First, rewinding head to replay your work on top of it...
Applying: - Make php-common "Multi-Arch: foreign" to indicate it has no
Using index info to reconstruct a base tree...
M debian/control
Falling back to patching base and 3-way merge...
Auto-merging debian/control
No changes -- Patch already applied.
Applying: - Drop sed dependency for php-common. sed is an Essential
Using index info to reconstruct a base tree...
M debian/control
Falling back to patching base and 3-way merge...
Auto-merging debian/control
No changes -- Patch already applied.
Usual tags pushed, ppa is:
ppa:
In Debian "8d1ad3fd d/control: Make php packages cross-installable to i386" contains our Delta.
It was actually re-fixed better (to not be geenrated away) in "07799e8c6" later.
The changelog is irrelevant as you want to sync it.
I didn't see anything suspicious in the build logs.
Checking the Delta in between for unwanted side-effects 76..debian/ 80_exp1
$ git log -p debian/
- dh10 -> ok
- git branch renaming -> ok
- adding php 8.0 (as alternative)
This is ok, but as we know those transition will need a lot of nudging to fully complete
I guess eventually for 21.10 we want only one PHP, so maybe take a note/card to drop
7.4 in time here?
- add xml to php-all-dev
This will be a component mismatch php-all-dev (main) -> php8.0-xml (universe)
So far src:php8.0 isn't promoted yet, this will need (a trivial) MIR
And is another case of "we then need to get rid of 7.4 this cycle"
- our Delta for i386 -> ok
- start the 8.0 transition properly -> yeah I've seen this coming above, make sense
This is dropping Ubuntu 12.04 code, which is fine
-
On thing thou, Debian-git already is preparing v82:
php-defaults (82) unstable; urgency=medium
* No change version bump.
php-defaults (81) unstable; urgency=medium
* php8.0: XMLRPC has been moved from base to PECL
* Add phpX.Y-mbstring to php-all-dev dependencies
* Add virtual php-gettext package
Making the package will pick those up as they appear, but only if they do so in -unstable.
Since it is unlikely for some months that it appears in unstable we might need to consider re-merging from git later on this cycle?
Due to the above php8.0-mbstring also will need to get to main.
I haven't found anything, but to be sure was any of those packages explicitly excluded in the past and would become a problem?
Overall:
- it does look all good to me
- yes we want to get the transition started and this is what it is doing
- You can
a) sync it now
b) or merge v82 from git
But for both maybe prepare the MIR for src:php8.0