Merge ~bryce/ubuntu/+source/php-defaults:7.4-transition into ubuntu/+source/php-defaults:debian/sid

Proposed by Bryce Harrington
Status: Merged
Approved by: Bryce Harrington
Approved revision: 0904994cabbf2573d0b034413bbf0cc4a2b2bf5b
Merge reported by: Andreas Hasenack
Merged at revision: 0904994cabbf2573d0b034413bbf0cc4a2b2bf5b
Proposed branch: ~bryce/ubuntu/+source/php-defaults:7.4-transition
Merge into: ubuntu/+source/php-defaults:debian/sid
Diff against target: 102 lines (+35/-6)
4 files modified
debian/changelog (+29/-0)
debian/control (+3/-4)
debian/control.in (+2/-1)
debian/rules (+1/-1)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Review via email: mp+379770@code.launchpad.net

This proposal supersedes a proposal from 2020-02-21.

Description of the change

Merge php-defaults from Debian unstable, to initiate the PHP 7.4 transition.

This drops all prior Ubuntu delta, as that was just reverting us to earlier versions of PHP -- essentially re-syncing to debian -- and then adds a small delta to drop 7.3. Debian is supporting both 7.3 and 7.4 whereas we want only 7.4.

This depends on php7.4, which has not yet migrated out of proposed due to its dependence on icu, so php-defaults also will be stuck in proposed for the time being. But this will permit staging the rest of the php dependencies. Once the icu transition finishes, and php7.4 lands, then this should go in too.

A spreadsheet with status of the other php dependencies is at:

https://docs.google.com/spreadsheets/d/11E6f6MTs0eTN-Nskap6iYT3l8QxTEuhYPlhy_z8Hd5s/edit#gid=1663657511

PPA for testing:

https://launchpad.net/~bryce/+archive/ubuntu/php7.4-transition

Bug report for tracking purposes is at:

https://bugs.launchpad.net/ubuntu/+source/php-defaults/+bug/1855020

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Posted in a previous version of this proposal

Ok, so you branched off salsa at:
commit 5f1073c4b528b3715378248352ea21a41ad853ce
Author: Ondřej Surý <email address hidden>
Date: Wed Jan 22 13:25:59 2020 +0100

    Update changelog for 72 release

You have some empty commits that I don't quite understand:
commit 5640be417e03cb44a4132480326e921354db6f49
Author: Bryce Harrington <email address hidden>
Date: Wed Feb 19 19:33:57 2020 +0000

      * Transition supported PHP version to php7.3

commit 93611a1f7be8f56cb618454aa5a0c58a02668aa0
Author: Bryce Harrington <email address hidden>
Date: Wed Feb 19 19:35:19 2020 +0000

      * Revert default and supported PHP version to 7.2

Given debian released v73 of this package, would a normal git-ubuntu merge work now? And as a suggestion, you can always cherry-pick unreleased changes from salsa as added delta, no need to fuss around with branches to try to get git-ubuntu to work (if that's what happened).

review: Needs Information
Revision history for this message
Bryce Harrington (bryce) wrote : Posted in a previous version of this proposal

Ok, I'll try again with another merge.

Revision history for this message
Bryce Harrington (bryce) wrote :

This new update merges against debian/sid's 73 package.

I've also updated the PPA with a copy of this php-defaults merge.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1!

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This already migrated to focal release.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 85a9df3..6355f90 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+php-defaults (73ubuntu1) focal; urgency=medium
7+
8+ * Merge with Debian unstable.
9+ - Drop previous transitions to earlier PHP versions 7.2 and 7.3.
10+ * d/control, d/rules: Change support for 7.3+7.4, to 7.4 only.
11+
12+ -- Bryce Harrington <bryce@canonical.com> Mon, 24 Feb 2020 13:09:22 -0800
13+
14 php-defaults (73) unstable; urgency=medium
15
16 * Add a small shell helper to update the default PHP-FPM socket location
17@@ -22,12 +30,33 @@ php-defaults (70) unstable; urgency=medium
18
19 -- Ondřej Surý <ondrej@sury.org> Wed, 14 Aug 2019 08:50:10 +0200
20
21+php-defaults (69ubuntu2) eoan; urgency=medium
22+
23+ [ Bryce Harrington ]
24+ * Transition supported PHP version to 7.3
25+
26+ -- Robie Basak <robie.basak@ubuntu.com> Fri, 23 Aug 2019 00:05:29 +0000
27+
28+php-defaults (69ubuntu1) disco; urgency=low
29+
30+ * Merge from Debian unstable. Remaining changes:
31+ - Revert default and supported PHP version to 7.2
32+
33+ -- Gianfranco Costamagna <locutusofborg@debian.org> Tue, 08 Jan 2019 09:19:27 +0100
34+
35 php-defaults (69) unstable; urgency=medium
36
37 * Add support for calling dismod in preinst scripts
38
39 -- Ondřej Surý <ondrej@debian.org> Mon, 17 Dec 2018 10:14:00 +0000
40
41+php-defaults (68ubuntu1) disco; urgency=medium
42+
43+ * Revert default and supported PHP version to 7.2
44+ since 7.3 requires pcre2. See bug 1636666
45+
46+ -- Jeremy Bicha <jbicha@ubuntu.com> Fri, 09 Nov 2018 12:34:51 -0500
47+
48 php-defaults (68) unstable; urgency=medium
49
50 * Make enabling/disabling modules silent (debug level)
51diff --git a/debian/control b/debian/control
52index bbb3646..6b18a51 100644
53--- a/debian/control
54+++ b/debian/control
55@@ -1,7 +1,8 @@
56 Source: php-defaults
57 Section: php
58 Priority: optional
59-Maintainer: Debian PHP Maintainers <team+pkg-php@tracker.debian.org>
60+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
61+XSBC-Original-Maintainer: Debian PHP Maintainers <team+pkg-php@tracker.debian.org>
62 Uploaders: Ondřej Surý <ondrej@debian.org>,
63 Lior Kaplan <kaplan@debian.org>
64 Standards-Version: 4.5
65@@ -52,9 +53,7 @@ Description: server-side, HTML-embedded scripting language (default)
66
67 Package: php-all-dev
68 Architecture: all
69-Depends: php7.3-dev,
70- php7.3-json,
71- php7.4-dev,
72+Depends: php7.4-dev,
73 php7.4-json,
74 ${misc:Depends}
75 Description: package depending on all supported PHP development packages
76diff --git a/debian/control.in b/debian/control.in
77index 337cee0..d2ee048 100644
78--- a/debian/control.in
79+++ b/debian/control.in
80@@ -1,7 +1,8 @@
81 Source: php-defaults
82 Section: php
83 Priority: optional
84-Maintainer: Debian PHP Maintainers <team+pkg-php@tracker.debian.org>
85+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
86+XSBC-Original-Maintainer: Debian PHP Maintainers <team+pkg-php@tracker.debian.org>
87 Uploaders: Ondřej Surý <ondrej@debian.org>,
88 Lior Kaplan <kaplan@debian.org>
89 Standards-Version: 4.5
90diff --git a/debian/rules b/debian/rules
91index 156294e..743aa4b 100755
92--- a/debian/rules
93+++ b/debian/rules
94@@ -10,7 +10,7 @@
95 include /usr/share/dpkg/default.mk
96
97 PHP_DEFAULT_VERSION := 7.4
98-PHP_SUPPORTED_VERSIONS := 7.3 7.4
99+PHP_SUPPORTED_VERSIONS := 7.4
100
101 , := ,
102 PHP_DEV_PACKAGES := $(addprefix php,$(addsuffix -dev$(,),$(PHP_SUPPORTED_VERSIONS))), $(addprefix php,$(addsuffix -json$(,),$(PHP_SUPPORTED_VERSIONS)))

Subscribers

People subscribed via source and target branches