Merge ~bryce/ubuntu/+source/node-nan:merge-v2.17.0-1-lunar into ubuntu/+source/node-nan:debian/sid
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | git-ubuntu bot | ||||
Approved revision: | not available | ||||
Merge reported by: | git-ubuntu bot | ||||
Merged at revision: | 961aa82db3ed0fb4333a2dff70e49a78acfd9b81 | ||||
Proposed branch: | ~bryce/ubuntu/+source/node-nan:merge-v2.17.0-1-lunar | ||||
Merge into: | ubuntu/+source/node-nan:debian/sid | ||||
Diff against target: |
110 lines (+64/-1) 4 files modified
debian/changelog (+26/-0) debian/control (+2/-1) debian/patches/disable-test-for-s390x.patch (+35/-0) debian/patches/series (+1/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
git-ubuntu bot | Approve | ||
Sergio Durigan Junior (community) | Approve | ||
Canonical Server | Pending | ||
Canonical Server Core Reviewers | Pending | ||
Canonical Server Reporter | Pending | ||
Review via email: mp+435771@code.launchpad.net |
Description of the change
Merge with Debian's package. The only delta is disabling a couple testcases for s390x. The delta for those is forwarded upstream but no response yet.
PPA: https:/
Autopkgtests (Local):
autopkgtest [21:09:25]: test pkg-js-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
pkg-
autopkgtest [21:09:25]: @@@@@@@
command1 PASS
pkg-
pkg-
Autopkgtests (PPA - from http://
node-nan @ armhf:
13.01.23 21:59:41 Log 🗒️ ✅ Triggers: node-nan/
command1 PASS 🟩
pkg-
pkg-
Running:
time pkg release arch ppa trigger
1112 node-nan lunar ppc64el bryce/node-
1112 node-nan lunar s390x bryce/node-
1122 node-nan lunar arm64 bryce/node-
40 node-nan lunar amd64 bryce/node-
I don't expect any of the remaining arches to fail, though s390x is the main one to be concerned with since I think upstream does not test on that arch.
Usual tags pushed for review:
- tags/old/debian 333f6e2
- tags/new/debian 58af960
- tags/old/ubuntu dbb7c30
- tags/logical/
- tags/reconstruc
- tags/split/
Thanks, Bryce.
Package build & tested fine (including the s390x test). Did you try verifying whether the delta is still necessary? It doesn't look like upstream addressed the underlying issue (and as you said, they don't seem to care about s390x), but I think it's worth a try anyway.
Otherwise, changes LGTM. +1