Code review comment for ~bryce/ubuntu/+source/node-nan:merge-v2.16.0-1-kinetic

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Bryce.

The package is "Architecture: all", so it won't build on non-amd64 architectures. The problem fixed by the patch doesn't seem to be fixed indeed; Debian is also affected by it, and we can see that the test is still failing there:

https://ci.debian.net/data/autopkgtest/unstable/s390x/n/node-nan/24616299/log.gz

Therefore, I agree that the delta should be kept.

BTW, this also means that it may be a good idea to send the patch to Debian and have the package become a sync.

Otherwise, LGTM. +1

review: Approve

« Back to merge proposal