Merge ~bryce/ubuntu/+source/logwatch:sru-lp1904362-groovy into ubuntu/+source/logwatch:ubuntu/groovy-devel

Proposed by Bryce Harrington
Status: Merged
Approved by: Bryce Harrington
Approved revision: 19c3fadbbb510897e1548770fc0e064eaec15226
Merged at revision: 19c3fadbbb510897e1548770fc0e064eaec15226
Proposed branch: ~bryce/ubuntu/+source/logwatch:sru-lp1904362-groovy
Merge into: ubuntu/+source/logwatch:ubuntu/groovy-devel
Diff against target: 69 lines (+47/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/allow-disabling-lookup.patch (+39/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Review via email: mp+405067@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

* Changelog:
  - [-] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [-] update-maintainer has been run

* Actual changes:
  - [-] no upstream changes to consider
  - [-] no further upstream version to consider
  - [-] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [-] nothing else to drop
  - [-] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [-] no new patches added
  - [√] patches match what was proposed upstream
  - [√] patches correctly included in debian/patches/series
  - [√] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [√] verified PPA package installs/uninstalls
  - [-] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

* There is one problem and it is not in the MR.
The SRU template section "[Where Problems Could Occur]" still has the template content.
Please update that before going to -unapproved.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for catching that, I've filled in the section in the SRU. Tagged & uploaded.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 850f2a9..595376a 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+logwatch (7.5.4-0ubuntu3.2) groovy; urgency=medium
7+
8+ * d/p/allow-disabling-lookup.patch: Allow skipping ip lookup
9+ (LP: #1904362)
10+
11+ -- Bryce Harrington <bryce@canonical.com> Thu, 01 Jul 2021 03:44:20 +0000
12+
13 logwatch (7.5.4-0ubuntu3.1) groovy; urgency=medium
14
15 * d/p/0010-zz-zfs-detect-zfs-location.patch: Use explicit paths for
16diff --git a/debian/patches/allow-disabling-lookup.patch b/debian/patches/allow-disabling-lookup.patch
17new file mode 100644
18index 0000000..e8881b5
19--- /dev/null
20+++ b/debian/patches/allow-disabling-lookup.patch
21@@ -0,0 +1,39 @@
22+From 88c0d675f10e425faeddd23316c061f425f39a06 Mon Sep 17 00:00:00 2001
23+From: bjorn <bjorn1@users.sourceforge.net>
24+Date: Sun, 20 Sep 2020 14:39:02 -0700
25+Subject: [PATCH logwatch] [sshd] Added LookupIP disable. Requested by Joseph
26+ Mocker.
27+
28+---
29+ conf/services/sshd.conf | 3 +++
30+ scripts/services/sshd | 1 +
31+ 2 files changed, 4 insertions(+)
32+
33+Origin: upstream, https://sourceforge.net/p/logwatch/git/ci/88c0d675f10e425faeddd23316c061f425f39a06/
34+Bug: https://sourceforge.net/p/logwatch/discussion/1115929/thread/952d84109c/
35+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/logwatch/+bug/1904362
36+Reviewed-By: Bryce Harrington <bryce@canonical.com>
37+Applied-Upstream: 7.5.5, commit:88c0d675f10e425faeddd23316c061f425f39a06
38+
39+--- a/conf/services/sshd.conf
40++++ b/conf/services/sshd.conf
41+@@ -43,6 +43,9 @@
42+ # specified threshold
43+ #$illegal_users_threshold = 4
44+
45++# Set to No to disable IP lookups
46++$sshd_ip_lookup = Yes
47++
48+
49+ ########################################################
50+ # This was written and is maintained by:
51+--- a/scripts/services/sshd
52++++ b/scripts/services/sshd
53+@@ -31,6 +31,7 @@
54+ my $IgnoreHost = $ENV{'sshd_ignore_host'} || "";
55+ my $RefusedConnectionsThreshold = $ENV{'refused_connections_threshold'} || 0;
56+ my $IllegalUsersThreshold = $ENV{'illegal_users_threshold'} || 0;
57++$main::DoLookup = $ENV{'sshd_ip_lookup'};
58+ my $DebugCounter = 0;
59+
60+ # No sense in running if 'sshd' doesn't even exist on this system...
61diff --git a/debian/patches/series b/debian/patches/series
62index 3c54a4f..943a302 100644
63--- a/debian/patches/series
64+++ b/debian/patches/series
65@@ -15,3 +15,4 @@
66 0019-exim-Handle-self-signed-certs-warnings.patch
67 0020-dhcpd-Ignore-lease-age-under-threshold-messages.patch
68 0021-audit-use-the-term-ALLOWED-instead-of-Grants.patch
69+allow-disabling-lookup.patch

Subscribers

People subscribed via source and target branches