Ubuntu
coreutils package

Code review comment for ~bryce/ubuntu/+source/coreutils:project-c2439-ignore-snaps-groovy

  1. Git
  2. lp:~bryce/ubuntu/+source/coreutils
  3. project-c2439-ignore-snaps-groovy
  4. Merge into ubuntu/devel
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the patch, Bryce!

After following the discussions on ubuntu-devel and the developments of the upstream bug, I decided I'd review it.

I ran some tests on a lxd VM (I had install snapd, and then "snap install" something inside the VM so that I could see the /snap/* mountpoints), and everything works as expected :-).

The patch itself is pretty simple; I just had two nits that I thought I'd point out. Otherwise, it looks OK to me! I'm marking the MP as "Approved" because I don't think it's worth doing another round just for the sake of these two nits.

Thanks again.

review: Approve

« Back to merge proposal