Code review comment for ~bryce/ubuntu/+source/apache2:sru-lp1565744-apache-lock-dir

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Straightforward case and fix, I found no issues other than "on its own" it would be debatable if it is worth an update. But since you plan to upload the fixes together that is ok.

One question thou, since we have placed things in /etc/ they will be config files.
Therefore "not delivering" them will not remove them from disk.

Is there a chance that people started to (wrongly) use that file and it would be active?

If not I think we should we also add an rm_conffile along the fix.

review: Needs Information

« Back to merge proposal