Merge ~bryce/ubuntu/+source/apache2:sru-lp1832182-graceful-focal into ubuntu/+source/apache2:ubuntu/focal-devel
Status: | Merged |
---|---|
Approved by: | Bryce Harrington on 2020-11-19 |
Approved revision: | 18974f5ac421332648b982f4f97bade9dc3fc480 |
Merge reported by: | Christian Ehrhardt |
Merged at revision: | 18974f5ac421332648b982f4f97bade9dc3fc480 |
Proposed branch: | ~bryce/ubuntu/+source/apache2:sru-lp1832182-graceful-focal |
Merge into: | ubuntu/+source/apache2:ubuntu/focal-devel |
Diff against target: |
98 lines (+40/-18) 2 files modified
debian/apache2ctl (+30/-18) debian/changelog (+10/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt | 2020-11-13 | Approve on 2020-11-17 | |
Ubuntu Server Dev import team | 2020-11-13 | Pending | |
Canonical Server Team | 2020-11-13 | Pending | |
Review via email:
|
Description of the change
Backport to focal of fix from
https:/
The start command was updated to work with systemd earlier; this extends the same fix for the 'graceful' command.
PPA: https:/
SRU: https:/
Forwarded to Debian: https:/
Christian Ehrhardt (paelzer) wrote : | # |
Christian Ehrhardt (paelzer) wrote : | # |
I remember reviewing the same fix for another release.
This one still LGTM and makes sense to avoid the direct restart breaking status detection.
Also changelog and version are ok.
The only thing I didn't get to this time is testing, have you run your PPA through upgrade tests already?
Christian Ehrhardt (paelzer) wrote : | # |
To keep discussions in one place also see https:/
Bryce Harrington (bryce) wrote : | # |
Sounds good, I've tagged, pushed, and uploaded this.
As reference, that old fix for start was at https:/ /bugs.debian. org/cgi- bin/bugreport. cgi?bug= 852543 in pkg/import/2.4.25-3