Merge ~bryce/ubuntu/+source/aodh:ubuntu/impish-devel into ubuntu/+source/aodh:ubuntu/devel

Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 6f97907e95f56aa26cecf29e1e05a48a28c7c710
Proposed branch: ~bryce/ubuntu/+source/aodh:ubuntu/impish-devel
Merge into: ubuntu/+source/aodh:ubuntu/devel
Diff against target: 40 lines (+20/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/drop-sqlalchemy-required-version.patch (+11/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Corey Bryant (community) Approve
Utkarsh Gupta (community) Approve
Sergio Durigan Junior (community) Approve
Chris MacNaughton Pending
Canonical Server packageset reviewers Pending
Review via email: mp+406685@code.launchpad.net

Description of the change

The -0ubuntu2 update dropped the sqlalchemy version requirement from d/control but there's also one in requirements.txt.

With this change, the package builds and autopkgtests pass for me:

autopkgtest [01:05:06]: @@@@@@@@@@@@@@@@@@@@ summary
aodh-daemons PASS
autodep8-python3 PASS (superficial)
autopkgtest [01:05:06]: Binaries: resetting testbed apt configuration

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Bryce. I agree with the proposed changes; one can easily check that the requirement for python3-sqlalchemy is still present in the generated .deb because of the expansion of ${python3:Depends}, which comes from the requirements.txt file.

review: Approve
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hey,

Reproduced the problem as noticed in https://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html#aodh & https://autopkgtest.ubuntu.com/results/autopkgtest-impish/impish/arm64/a/aodh/20210802_124549_91ca1@/log.gz.

Verified that your patch works. Rebuilt and ran the autopkgtest with success:
autopkgtest [17:12:01]: @@@@@@@@@@@@@@@@@@@@ summary
aodh-daemons PASS
autodep8-python3 PASS (superficial)

So, a +1. Go, go, go!

review: Approve
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Thanks Bryce! I'll get this merged and uploaded.

review: Approve
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 10ca17c..54bc450 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+aodh (1:12.0.0+git2021072116.10383f4d-0ubuntu3) impish; urgency=medium
7+
8+ * d/p/drop-sqlalchemy-required-version.patch: Remove dependency on
9+ unavailable sqlalchemy 1.4.
10+ (LP: #1938962)
11+
12+ -- Bryce Harrington <bryce@canonical.com> Thu, 05 Aug 2021 00:37:55 +0000
13+
14 aodh (1:12.0.0+git2021072116.10383f4d-0ubuntu2) impish; urgency=medium
15
16 * d/control: Drop python3-sqlalchemy min version.
17diff --git a/debian/patches/drop-sqlalchemy-required-version.patch b/debian/patches/drop-sqlalchemy-required-version.patch
18new file mode 100644
19index 0000000..c1cb344
20--- /dev/null
21+++ b/debian/patches/drop-sqlalchemy-required-version.patch
22@@ -0,0 +1,11 @@
23+--- a/requirements.txt
24++++ b/requirements.txt
25+@@ -26,7 +26,7 @@
26+ pytz>=2013.6
27+ requests>=2.5.2
28+ stevedore>=1.5.0 # Apache-2.0
29+-sqlalchemy>=1.4.1
30++sqlalchemy
31+ tooz>=1.28.0 # Apache-2.0
32+ voluptuous>=0.8.10
33+ WebOb>=1.2.3
34diff --git a/debian/patches/series b/debian/patches/series
35index 92092ac..c4c8f84 100644
36--- a/debian/patches/series
37+++ b/debian/patches/series
38@@ -1 +1,2 @@
39+drop-sqlalchemy-required-version.patch
40 remove-wsmeext.sphinxext.patch

Subscribers

People subscribed via source and target branches