Code review comment for ppa-dev-tools:tests-dashboard

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Hi Bryce! Nice work :)

This LGTM. I added a few inline comments below. As usual, feel free to ignore/act upon them as you please, since they are mostly minor nitpicks.

For large patch sets, it would be nice to have refactoring changes in their own commits.
For instance, bfd3865 is described as a test change/introduction, but also refactors a few code snippets to change a param name. Splitting this in different commits could help reviewers or any future change analysis that may be needed.

review: Approve

« Back to merge proposal