lp:~bryce/launchpad/lp-617698-forwarding

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:launchpad/db-devel

Jeroen T. Vermeulen (community): Approve (code) on 2011-04-27

Bryce Harrington (community): Needs Resubmitting on 2011-04-25

Diff: 1109 lines (+705/-45)

17 files modified

lib/canonical/launchpad/scripts/bzremotecomponentfinder.py (+6/-2)
lib/lp/bugs/browser/bugalsoaffects.py (+23/-7)
lib/lp/bugs/browser/bugtracker.py (+106/-4)
lib/lp/bugs/browser/configure.zcml (+9/-0)
lib/lp/bugs/browser/tests/bugtask-adding-views.txt (+1/-1)
lib/lp/bugs/browser/tests/test_bugtracker_component.py (+189/-0)
lib/lp/bugs/browser/widgets/bugtask.py (+20/-0)
lib/lp/bugs/doc/bugtracker.txt (+13/-20)
lib/lp/bugs/interfaces/bugtracker.py (+8/-2)
lib/lp/bugs/model/bugtracker.py (+29/-9)
lib/lp/bugs/templates/bugtracker-edit-component.pt (+16/-0)
lib/lp/bugs/templates/bugtracker-index.pt (+2/-0)
lib/lp/bugs/templates/bugtracker-portlet-components.pt (+36/-0)
lib/lp/registry/configure.zcml (+1/-0)
lib/lp/registry/interfaces/sourcepackage.py (+2/-0)
lib/lp/registry/model/sourcepackage.py (+11/-0)
lib/lp/services/features/scopes.py (+233/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #617698: When forwarding a bug to an external bug tracker, the component field doesn't get filled in

High

Triaged

Link a bug report

Related blueprints

9968. By Bryce Harrington on 2011-05-19

Review from jeroen: Move component/sourcepackage check to a new
member function of SourcePackage.

9967. By Bryce Harrington on 2011-05-18

Review from jeroen: Typo for "searched"?

9966. By Bryce Harrington on 2011-05-18

Review from jeroen: "Commented-out code is a bad thing."

9965. By Bryce Harrington on 2011-05-18

Review from jeroen: "Also note that a count() on the query can be
relatively expensive and deliver more information than you need. If all
you need to know is whether there are any at all, use is_empty() instead"

9964. By Bryce Harrington on 2011-04-25

Re-merge db-devel trunk

9963. By Bryce Harrington on 2011-04-25

Revert Jeroen's change for component form so editing components works.

In review, Jeroen noticed I had an ugly if clause to look up the source
package name field for the component edit form, and suggested replacing
it with a dict to look up the fields.

Unfortunately, it's not so simple. The SourcePackageName object is not
a string property, so has to be handled differently than other kinds of
objects (we have to explicitly reference it's .name field to get the
string out of it). So the None check and special handling of this field
is required. Otherwise, an Oops occurs when it tries to fill in the
package name field with the object rather than the string.

9962. By Bryce Harrington on 2011-04-25

Compare string against the '.name' field of DSP rather than object itself.

9961. By Bryce Harrington on 2011-01-24

Adjust to new widgets location

9960. By Bryce Harrington on 2011-01-24

Re-merge db-devel trunk

9959. By Bryce Harrington on 2011-01-24

Giving up on feature flags stuff and ripping it out.

The flags work fine in the browser when setting the flag manually, but
I just can't sort out how to get the unittests to recognize it. This
issue has been blocking progress on this branch for months now, and I've
failed to find anyone who can explain how to make it work properly.
Martin Pool suggested just dropping it and moving on, which sounds good
to me.