Merge lp:~bryce/apport/bug-1831802 into lp:~apport-hackers/apport/trunk

[Bryce Harrington]

data/general-hooks/generic.py: Don't file bug reports about out-of-space conditions

For package installation problems, if the problem is due to insufficient
disk space then treat it as an unreportable error.

Fixes: LP: #1831802

If package installation failed due to out-of-disk-space, it isn't necessary to file a bug report about it, so filter these.

[Bryce Harrington (bryce)]

Googling a bit more, this error message may be originating from mysql, in which case an alternative approach might be to parse Df.txt for 100% usage on /.

I don't know how prevalent this particular type of bug report is. There is already code to check disk space at bug filing time, which may catch most of these, but won't catch if the system ran out of space during installation.

[Brian Murray (brian-murray)]

The error message does in fact come from mysql as we can in the presint:

167 # checking disc space
168 if LC_ALL=C BLOCKSIZE= df --portability $DATADIR/. | tail -n 1 | awk '{ exit ($4>1000) }'; then
169 echo "ERROR: There's not enough space in $DATADIR/" 1>&2
170 db_stop
171 exit 1
172 fi

So the string checking you've added would make more sense in the mysql apport package hook, that being said it is curious that the referenced bug report got reported to Launchpad at all. I'd have expected there to be an UnreportableReason regarding the partition not having enough free space.

Unmerged revisions

3255. By Bryce Harrington on 2019-06-05

data/general-hooks/generic.py: Don't file bug reports about out-of-space conditions

For package installation problems, if the problem is due to insufficient
disk space then treat it as an unreportable error.

3254. By Bryce Harrington on 2019-06-05

data/general-hooks/generic.py: Fix misspelled variable

=== modified file 'data/general-hooks/generic.py'
--- data/general-hooks/generic.py	2018-02-13 00:50:36 +0000
+++ data/general-hooks/generic.py	2019-06-05 21:17:15 +0000
@@ -28,13 +28,13 @@
     home = os.getenv('HOME')
     if home:
         mounts[home] = 'home'
-    treshold = 50
+    threshold = 50
 
     for mount in mounts:
         st = os.statvfs(mount)
         free_mb = st.f_bavail * st.f_frsize / 1000000
 
-        if free_mb < treshold:
+        if free_mb < threshold:
             report['UnreportableReason'] = 'Your %s partition has less than \
 %s MB of free space available, which leads to problems using applications \
 and installing updates. Please free some space.' % (mounts[mount], free_mb)
@@ -81,6 +81,12 @@
     in_gl = '/usr/lib/libGL.so' in (report.get('StacktraceTop') or '\n').splitlines()[0]
     if in_gl and 'Loading extension GLX' not in apport.hookutils.read_file('/var/log/Xorg.0.log'):
         report['UnreportableReason'] = 'The X.org server does not support the GLX extension, which the crashed program expected to use.'
+
+    # filter out package install failures due to insufficient disk space
+    if 'ERROR: There\'s not enough space in' in report.get('DpkgTerminalLog')
+        and report['ProblemType'] == 'Package':
+        report['UnreportableReason'] = 'The package installation failed because your system did not have enough free space available. Please free some space to avoid problems using applications and installing updates.'
+
     # filter out package install failures due to a segfault
     if 'Segmentation fault' in report.get('ErrorMessage', '') \
             and report['ProblemType'] == 'Package':