Code review comment for ~bryce/+git/php-parser:fix-lp1878102-groovy

On Wed, May 13, 2020 at 01:22:22PM -0000, Lucas Kanashiro wrote:
> Review: Approve
>
> About the applied patches, didn't you forget to remove your patch? Anyway, I checked the debdiff and it LGTM.

Thanks for the review.

Weirdly, the package doesn't build unless the patch is applied. I
suspect it is one of the odd cases where the package ships with quilt
push.

Bryce

> * Changelog:
> - [-] old content and logical tag match as expected
> - [√] changelog entry correct version and targeted codename
> - [√] changelog entries correct
> - [√] update-maintainer has been run
>
> * Actual changes:
> - [-] no upstream changes to consider
> - [-] no further upstream version to consider
> - [-] debian changes look safe
>
> * Old Delta:
> - [-] dropped changes are ok to be dropped
> - [-] nothing else to drop
> - [-] changes forwarded upstream/debian (if appropriate)
>
> * New Delta:
> - [-] no new patches added
> - [-] patches match what was proposed upstream
> - [√] patches correctly included in debian/patches/series
> - [√] patches have correct DEP3 metadata
>
> * Build/Test:
> - [√] build is ok
> - [√] verified PPA package installs/uninstalls
> - [√] autopkgtest against the PPA package passes
> - [√] sanity checks test fine
>
> --
> https://code.launchpad.net/~bryce/+git/php-parser/+merge/383830
> You are the owner of ~bryce/+git/php-parser:fix-lp1878102-groovy.