Merge lp:~bryan-tongminh/bzr-webdav/ctype-fix into lp:bzr-webdav

[Bryan-tongminh]

Not specifying a content-type header caused urllib2 to send the PROPFIND request as application/www-form-urlencoded, causing IIS6 to return a 415 error code. Sending the appropriate Content-type: application/xml fixes this.

[Vincent Ladeuil (vila)]

Thanks for catching that, there is another request that needs the same fix, I'll do that while merging.

review: Approve

[Vincent Ladeuil (vila)]

Hmm, RFC2518 uses 'text/xml' rather than 'application/xml'. Does the former also address the issue for you ? I'd rather use that if that's the case.

review: Needs Fixing

[Bryan-tongminh (bryan-tongminh)]

RFC4918 uses application/xml in its examples: http://webdav.org/specs/rfc4918.html#METHOD_PROPFIND

As far as I'm aware it should not matter which one to use. I'll see if I can test it later this week.

[Vincent Ladeuil (vila)]

> RFC4918 uses application/xml in its examples: http://webdav.org/specs/rfc4918.html#METHOD_PROPFIND

Argh ! <paper:rfc2518?page=22> ! You betrayed me !

> As far as I'm aware it should not matter which one to use.

I thought so too, but I've switched to application/xml anyway :)

> I'll see if I can test it later this week.

Thanks, not needed anymore :)

=== modified file 'webdav.py'
--- webdav.py	2011-06-14 09:21:57 +0000
+++ webdav.py	2011-10-02 14:38:29 +0000
@@ -762,8 +762,9 @@
    </D:propfind>
 """
         request = _urllib2_wrappers.Request('PROPFIND', abspath, propfind,
-                                            {'Depth': '0'},
+                                            {'Depth': '0', 'Content-Type': 'application/xml; charset="utf-8"'},
                                             accepted_errors=[207, 404, 409,])
+
         response = self._perform(request)
 
         code = response.code